* [net-next 0/5] use reset to set headers
@ 2016-12-02 1:51 Zhang Shengju
2016-12-02 1:51 ` [net-next 1/5] qede: use reset to set network header Zhang Shengju
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-12-02 1:51 UTC (permalink / raw)
To: netdev
This patch serial replace 'set' function to 'reset', since the offset is zero.
It's not necessary to use set, reset function is straightforward, and will
remove the unnecessary add operation in set function.
Zhang Shengju (5):
qede: use reset to set network header
bnx2x: use reset to set network header
mlx4: use reset to set mac header
iwlwifi: use reset to set transport header
staging: wilc1000: use reset to set mac header
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +-
drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 2 +-
drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +-
drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 2 +-
drivers/staging/wilc1000/linux_mon.c | 4 ++--
5 files changed, 6 insertions(+), 6 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [net-next 1/5] qede: use reset to set network header
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
@ 2016-12-02 1:51 ` Zhang Shengju
2016-12-02 7:35 ` Mintz, Yuval
2016-12-02 1:51 ` [net-next 2/5] bnx2x: " Zhang Shengju
` (4 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Zhang Shengju @ 2016-12-02 1:51 UTC (permalink / raw)
To: netdev
Since offset is zero, it's not necessary to use set function. Reset
function is straightforward, and will remove the unnecessary add
operation in set function.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index b84a2c4..31c8449 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -1220,7 +1220,7 @@ static void qede_gro_receive(struct qede_dev *edev,
#ifdef CONFIG_INET
if (skb_shinfo(skb)->gso_size) {
- skb_set_network_header(skb, 0);
+ skb_reset_network_header(skb);
switch (skb->protocol) {
case htons(ETH_P_IP):
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [net-next 2/5] bnx2x: use reset to set network header
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
2016-12-02 1:51 ` [net-next 1/5] qede: use reset to set network header Zhang Shengju
@ 2016-12-02 1:51 ` Zhang Shengju
2016-12-02 1:51 ` [net-next 3/5] mlx4: use reset to set mac header Zhang Shengju
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-12-02 1:51 UTC (permalink / raw)
To: netdev
Since offset is zero, it's not necessary to use set function. Reset
function is straightforward, and will remove the unnecessary add
operation in set function.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index 3fd36b4..3e199d3 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
@@ -724,7 +724,7 @@ static void bnx2x_gro_ipv6_csum(struct bnx2x *bp, struct sk_buff *skb)
static void bnx2x_gro_csum(struct bnx2x *bp, struct sk_buff *skb,
void (*gro_func)(struct bnx2x*, struct sk_buff*))
{
- skb_set_network_header(skb, 0);
+ skb_reset_network_header(skb);
gro_func(bp, skb);
tcp_gro_complete(skb);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [net-next 3/5] mlx4: use reset to set mac header
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
2016-12-02 1:51 ` [net-next 1/5] qede: use reset to set network header Zhang Shengju
2016-12-02 1:51 ` [net-next 2/5] bnx2x: " Zhang Shengju
@ 2016-12-02 1:51 ` Zhang Shengju
2016-12-02 1:51 ` [net-next 4/5] iwlwifi: use reset to set transport header Zhang Shengju
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-12-02 1:51 UTC (permalink / raw)
To: netdev
Since offset is zero, it's not necessary to use set function. Reset
function is straightforward, and will remove the unnecessary add
operation in set function.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_selftest.c b/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
index c06346a..95290e1 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
@@ -68,7 +68,7 @@ static int mlx4_en_test_loopback_xmit(struct mlx4_en_priv *priv)
memcpy(ethh->h_dest, priv->dev->dev_addr, ETH_ALEN);
eth_zero_addr(ethh->h_source);
ethh->h_proto = htons(ETH_P_ARP);
- skb_set_mac_header(skb, 0);
+ skb_reset_mac_header(skb);
for (i = 0; i < packet_size; ++i) /* fill our packet */
packet[i] = (unsigned char)(i & 0xff);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [net-next 4/5] iwlwifi: use reset to set transport header
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
` (2 preceding siblings ...)
2016-12-02 1:51 ` [net-next 3/5] mlx4: use reset to set mac header Zhang Shengju
@ 2016-12-02 1:51 ` Zhang Shengju
2016-12-02 1:51 ` [net-next 5/5] staging: wilc1000: use reset to set mac header Zhang Shengju
2016-12-03 20:49 ` [net-next 0/5] use reset to set headers David Miller
5 siblings, 0 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-12-02 1:51 UTC (permalink / raw)
To: netdev
Since offset is zero, it's not necessary to use set function. Reset
function is straightforward, and will remove the unnecessary add
operation in set function.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c
index 5f840f1..e44e5ad 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c
@@ -2196,7 +2196,7 @@ static int iwl_fill_data_tbs_amsdu(struct iwl_trans *trans, struct sk_buff *skb,
memcpy(skb_put(csum_skb, tcp_hdrlen(skb)),
tcph, tcp_hdrlen(skb));
- skb_set_transport_header(csum_skb, 0);
+ skb_reset_transport_header(csum_skb);
csum_skb->csum_start =
(unsigned char *)tcp_hdr(csum_skb) -
csum_skb->head;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [net-next 5/5] staging: wilc1000: use reset to set mac header
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
` (3 preceding siblings ...)
2016-12-02 1:51 ` [net-next 4/5] iwlwifi: use reset to set transport header Zhang Shengju
@ 2016-12-02 1:51 ` Zhang Shengju
2016-12-03 20:49 ` [net-next 0/5] use reset to set headers David Miller
5 siblings, 0 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-12-02 1:51 UTC (permalink / raw)
To: netdev
Since offset is zero, it's not necessary to use set function. Reset
function is straightforward, and will remove the unnecessary add
operation in set function.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/staging/wilc1000/linux_mon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c
index 242f82f..f328d75 100644
--- a/drivers/staging/wilc1000/linux_mon.c
+++ b/drivers/staging/wilc1000/linux_mon.c
@@ -111,7 +111,7 @@ void WILC_WFI_monitor_rx(u8 *buff, u32 size)
}
skb->dev = wilc_wfi_mon;
- skb_set_mac_header(skb, 0);
+ skb_reset_mac_header(skb);
skb->ip_summed = CHECKSUM_UNNECESSARY;
skb->pkt_type = PACKET_OTHERHOST;
skb->protocol = htons(ETH_P_802_2);
@@ -215,7 +215,7 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
cb_hdr->tx_flags = 0x0004;
skb2->dev = wilc_wfi_mon;
- skb_set_mac_header(skb2, 0);
+ skb_reset_mac_header(skb2);
skb2->ip_summed = CHECKSUM_UNNECESSARY;
skb2->pkt_type = PACKET_OTHERHOST;
skb2->protocol = htons(ETH_P_802_2);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [net-next 1/5] qede: use reset to set network header
2016-12-02 1:51 ` [net-next 1/5] qede: use reset to set network header Zhang Shengju
@ 2016-12-02 7:35 ` Mintz, Yuval
0 siblings, 0 replies; 8+ messages in thread
From: Mintz, Yuval @ 2016-12-02 7:35 UTC (permalink / raw)
To: Zhang Shengju, netdev@vger.kernel.org
> Since offset is zero, it's not necessary to use set function. Reset
> function is straightforward, and will remove the unnecessary add
> operation in set function.
Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
[For #2 for bnx2x as well]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [net-next 0/5] use reset to set headers
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
` (4 preceding siblings ...)
2016-12-02 1:51 ` [net-next 5/5] staging: wilc1000: use reset to set mac header Zhang Shengju
@ 2016-12-03 20:49 ` David Miller
5 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-12-03 20:49 UTC (permalink / raw)
To: zhangshengju; +Cc: netdev
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Fri, 2 Dec 2016 09:51:02 +0800
> This patch serial replace 'set' function to 'reset', since the
> offset is zero. It's not necessary to use set, reset function is
> straightforward, and will remove the unnecessary add operation in
> set function.
Series applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-12-03 20:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-02 1:51 [net-next 0/5] use reset to set headers Zhang Shengju
2016-12-02 1:51 ` [net-next 1/5] qede: use reset to set network header Zhang Shengju
2016-12-02 7:35 ` Mintz, Yuval
2016-12-02 1:51 ` [net-next 2/5] bnx2x: " Zhang Shengju
2016-12-02 1:51 ` [net-next 3/5] mlx4: use reset to set mac header Zhang Shengju
2016-12-02 1:51 ` [net-next 4/5] iwlwifi: use reset to set transport header Zhang Shengju
2016-12-02 1:51 ` [net-next 5/5] staging: wilc1000: use reset to set mac header Zhang Shengju
2016-12-03 20:49 ` [net-next 0/5] use reset to set headers David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).