From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, nogahf@mellanox.com, arkadis@mellanox.com,
ogerlitz@mellanox.com, roopa@cumulusnetworks.com,
dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
andy@greyhouse.net, vivien.didelot@savoirfairelinux.com,
andrew@lunn.ch, f.fainelli@gmail.com,
alexander.h.duyck@intel.com, hannes@stressinduktion.org,
kaber@trash.net
Subject: Re: [patch net-next v4 00/10] ipv4: fib: Replay events when registering FIB notifier
Date: Sat, 03 Dec 2016 19:30:02 -0500 (EST) [thread overview]
Message-ID: <20161203.193002.1316709458884546814.davem@davemloft.net> (raw)
In-Reply-To: <1480779907-32535-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 3 Dec 2016 16:44:57 +0100
> Ido says:
>
> In kernel 4.9 the switchdev-specific FIB offload mechanism was replaced
> by a new FIB notification chain to which modules could register in order
> to be notified about the addition and deletion of FIB entries. The
> motivation for this change was that switchdev drivers need to be able to
> reflect the entire FIB table and not only FIBs configured on top of the
> port netdevs themselves. This is useful in case of in-band management.
>
> The fundamental problem with this approach is that upon registration
> listeners lose all the information previously sent in the chain and
> thus have an incomplete view of the FIB tables, which can result in
> packet loss. This patchset fixes that by dumping the FIB tables and
> replaying notifications previously sent in the chain for the registered
> notification block.
>
> The entire dump process is done under RCU and thus the FIB notification
> chain is converted to be atomic. The listeners are modified accordingly.
> This is done in the first eight patches.
>
> The ninth patch adds a change sequence counter to ensure the integrity
> of the FIB dump. The last patch adds the dump itself to the FIB chain
> registration function and modifies existing listeners to pass a callback
> to be executed in case dump was inconsistent.
...
Series applied, thanks.
prev parent reply other threads:[~2016-12-04 0:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 15:44 [patch net-next v4 00/10] ipv4: fib: Replay events when registering FIB notifier Jiri Pirko
2016-12-03 15:44 ` [patch net-next v4 01/10] ipv4: fib: Export free_fib_info() Jiri Pirko
2016-12-03 15:44 ` [patch net-next v4 02/10] ipv4: fib: Add fib_info_hold() helper Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 03/10] mlxsw: core: Create an ordered workqueue for FIB offload Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 04/10] mlxsw: spectrum_router: Implement FIB offload in deferred work Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 05/10] rocker: Create an ordered workqueue for FIB offload Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 06/10] rocker: Implement FIB offload in deferred work Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 07/10] rocker: Register FIB notifier before creating ports Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 08/10] ipv4: fib: Convert FIB notification chain to be atomic Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 09/10] ipv4: fib: Allow for consistent FIB dumping Jiri Pirko
2016-12-03 15:45 ` [patch net-next v4 10/10] ipv4: fib: Replay events when registering FIB notifier Jiri Pirko
2016-12-04 0:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203.193002.1316709458884546814.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=arkadis@mellanox.com \
--cc=dsa@cumulusnetworks.com \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).