From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net-next 8/8] tcp: tsq: move tsq_flags close to sk_wmem_alloc Date: Sat, 03 Dec 2016 20:37:08 -0500 (EST) Message-ID: <20161203.203708.151248945683979245.davem@davemloft.net> References: <1480792497-16607-9-git-send-email-edumazet@google.com> <20161203.191626.976921736888291388.davem@davemloft.net> <1480814031.18162.439.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: edumazet@google.com, netdev@vger.kernel.org, ycheng@google.com To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:59324 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcLECcC (ORCPT ); Sun, 4 Dec 2016 21:32:02 -0500 In-Reply-To: <1480814031.18162.439.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Sat, 03 Dec 2016 17:13:51 -0800 > On Sat, 2016-12-03 at 19:16 -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Sat, 3 Dec 2016 11:14:57 -0800 >> >> > diff --git a/include/linux/tcp.h b/include/linux/tcp.h >> > index d8be083ab0b0..fc5848dad7a4 100644 >> > --- a/include/linux/tcp.h >> > +++ b/include/linux/tcp.h >> > @@ -186,7 +186,6 @@ struct tcp_sock { >> > u32 tsoffset; /* timestamp offset */ >> > >> > struct list_head tsq_node; /* anchor in tsq_tasklet.head list */ >> > - unsigned long tsq_flags; >> > >> > /* Data for direct copy to user */ >> > struct { >> >> Hmmm, did you forget to "git add include/net/sock.h" before making >> this commit? > > sk_tsq_flags was added in prior patch in the series ( 7/8 net: > reorganize struct sock for better data locality) > > What is the problem with this part ? Sorry, just noticed by visual inspection. I expected the struct sock part to show up in the same patch as the one that removed it from tcp_sock and adjusted the users. I'll re-review this series, thanks.