From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH net] geneve: avoid use-after-free of skb->data
Date: Sat, 03 Dec 2016 23:11:38 -0500 (EST) [thread overview]
Message-ID: <20161203.231138.1619556323782350736.davem@davemloft.net> (raw)
In-Reply-To: <20161203003326.GA27610@bistromath.localdomain>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Sat, 3 Dec 2016 01:33:26 +0100
> I'd like to try something based on static analysis. We'd need a way to
> tag cached pointers to skb->data (via ip_hdr() or whatever), and
> propagate the notion that pskb_expand_head() makes these cached
> pointers stale through layers of function calls. I don't know how
> feasible this is with the tools we have.
Perhaps create helpers that have some special attribute attached to
them like "skb_volatile" or whatever. ip_hdr() et al would go through
them.
Then the static analysis tool is told that pskb_expand_head() "kills"
all skb_volatile obtained values, and it could basically mark all such
variables as uninitialized.
prev parent reply other threads:[~2016-12-04 4:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 15:49 [PATCH net] geneve: avoid use-after-free of skb->data Sabrina Dubroca
2016-12-02 18:33 ` John W. Linville
2016-12-02 19:09 ` David Miller
2016-12-03 0:33 ` Sabrina Dubroca
2016-12-04 4:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161203.231138.1619556323782350736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).