netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rshearma@brocade.com
Cc: alexander.h.duyck@intel.com, netdev@vger.kernel.org
Subject: Re: [net PATCH 2/2] ipv4: Drop suffix update from resize code
Date: Mon, 05 Dec 2016 12:28:46 -0500 (EST)	[thread overview]
Message-ID: <20161205.122846.557360857895468724.davem@davemloft.net> (raw)
In-Reply-To: <46f96f3a-0e8a-5eff-0f2d-7aeb6aec8c23@brocade.com>

From: Robert Shearman <rshearma@brocade.com>
Date: Mon, 5 Dec 2016 15:05:18 +0000

> On 01/12/16 12:27, Alexander Duyck wrote:
>> It has been reported that update_suffix can be expensive when it is
>> called
>> on a large node in which most of the suffix lengths are the same.  The
>> time
>> required to add 200K entries had increased from around 3 seconds to
>> almost
>> 49 seconds.
>>
>> In order to address this we need to move the code for updating the
>> suffix
>> out of resize and instead just have it handled in the cases where we
>> are
>> pushing a node that increases the suffix length, or will decrease the
>> suffix length.
>>
>> Fixes: 5405afd1a306 ("fib_trie: Add tracking value for suffix length")
>> Reported-by: Robert Shearman <rshearma@brocade.com>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> $ time sudo ip route restore < ~/allroutes
> RTNETLINK answers: File exists
> RTNETLINK answers: File exists
> RTNETLINK answers: File exists
> RTNETLINK answers: File exists

What are these errors all about?

  reply	other threads:[~2016-12-05 17:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 12:27 [net PATCH 0/2] IPv4 FIB suffix length fixes Alexander Duyck
2016-12-01 12:27 ` [net PATCH 1/2] ipv4: Drop leaf from suffix pull/push functions Alexander Duyck
2016-12-05 15:05   ` Robert Shearman
2016-12-01 12:27 ` [net PATCH 2/2] ipv4: Drop suffix update from resize code Alexander Duyck
2016-12-05 15:05   ` Robert Shearman
2016-12-05 17:28     ` David Miller [this message]
2016-12-05 17:36       ` Duyck, Alexander H
2016-12-05 19:27       ` Robert Shearman
2016-12-05 18:16 ` [net PATCH 0/2] IPv4 FIB suffix length fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161205.122846.557360857895468724.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexander.h.duyck@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=rshearma@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).