* [PATCH] net: phy: dp83848: Support ethernet pause frames
@ 2016-12-02 14:22 Jesper Nilsson
2016-12-02 14:35 ` Andrew F. Davis
2016-12-02 14:57 ` [PATCH v2] " Jesper Nilsson
0 siblings, 2 replies; 5+ messages in thread
From: Jesper Nilsson @ 2016-12-02 14:22 UTC (permalink / raw)
To: Florian Fainelli
Cc: Roger Quadros, Andrew F. Davis, David S. Miller, Dan Murphy,
netdev, linux-kernel
According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/net/phy/dp83848.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..6e4117f 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
.phy_id = _id, \
.phy_id_mask = 0xfffffff0, \
.name = _name, \
- .features = PHY_BASIC_FEATURES, \
+ .features = (PHY_BASIC_FEATURES | \
+ SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
.flags = PHY_HAS_INTERRUPT, \
\
.soft_reset = genphy_soft_reset, \
--
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: phy: dp83848: Support ethernet pause frames
2016-12-02 14:22 [PATCH] net: phy: dp83848: Support ethernet pause frames Jesper Nilsson
@ 2016-12-02 14:35 ` Andrew F. Davis
2016-12-02 14:52 ` Jesper Nilsson
2016-12-02 14:57 ` [PATCH v2] " Jesper Nilsson
1 sibling, 1 reply; 5+ messages in thread
From: Andrew F. Davis @ 2016-12-02 14:35 UTC (permalink / raw)
To: Jesper Nilsson, Florian Fainelli
Cc: Roger Quadros, David S. Miller, Dan Murphy, netdev, linux-kernel
On 12/02/2016 08:22 AM, Jesper Nilsson wrote:
> According to the documentation, the PHYs supported by this driver
> can also support pause frames. Announce this to be so.
> Tested with a TI83822I.
>
Looks like all PHYs supported by this driver do, so:
Acked-by: Andrew F. Davis <afd@ti.com>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
> ---
> drivers/net/phy/dp83848.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
> index 800b39f..6e4117f 100644
> --- a/drivers/net/phy/dp83848.c
> +++ b/drivers/net/phy/dp83848.c
> @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
> .phy_id = _id, \
> .phy_id_mask = 0xfffffff0, \
> .name = _name, \
> - .features = PHY_BASIC_FEATURES, \
> + .features = (PHY_BASIC_FEATURES | \
> + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
Aligning these may look nicer though.
> .flags = PHY_HAS_INTERRUPT, \
> \
> .soft_reset = genphy_soft_reset, \
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: phy: dp83848: Support ethernet pause frames
2016-12-02 14:35 ` Andrew F. Davis
@ 2016-12-02 14:52 ` Jesper Nilsson
0 siblings, 0 replies; 5+ messages in thread
From: Jesper Nilsson @ 2016-12-02 14:52 UTC (permalink / raw)
To: Andrew F. Davis
Cc: Jesper Nilsson, Florian Fainelli, Roger Quadros, David S. Miller,
Dan Murphy, netdev, linux-kernel
On Fri, Dec 02, 2016 at 08:35:23AM -0600, Andrew F. Davis wrote:
> On 12/02/2016 08:22 AM, Jesper Nilsson wrote:
> > According to the documentation, the PHYs supported by this driver
> > can also support pause frames. Announce this to be so.
> > Tested with a TI83822I.
> >
>
> Looks like all PHYs supported by this driver do, so:
>
> Acked-by: Andrew F. Davis <afd@ti.com>
>
> > Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
> > ---
> > drivers/net/phy/dp83848.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
> > index 800b39f..6e4117f 100644
> > --- a/drivers/net/phy/dp83848.c
> > +++ b/drivers/net/phy/dp83848.c
> > @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
> > .phy_id = _id, \
> > .phy_id_mask = 0xfffffff0, \
> > .name = _name, \
> > - .features = PHY_BASIC_FEATURES, \
> > + .features = (PHY_BASIC_FEATURES | \
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
>
> Aligning these may look nicer though.
Agreed, will send a v2.
> > .flags = PHY_HAS_INTERRUPT, \
> > \
> > .soft_reset = genphy_soft_reset, \
> >
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] net: phy: dp83848: Support ethernet pause frames
2016-12-02 14:22 [PATCH] net: phy: dp83848: Support ethernet pause frames Jesper Nilsson
2016-12-02 14:35 ` Andrew F. Davis
@ 2016-12-02 14:57 ` Jesper Nilsson
2016-12-05 18:14 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Jesper Nilsson @ 2016-12-02 14:57 UTC (permalink / raw)
To: Florian Fainelli
Cc: Roger Quadros, Andrew F. Davis, David S. Miller, Dan Murphy,
netdev, linux-kernel
According to the documentation, the PHYs supported by this driver
can also support pause frames. Announce this to be so.
Tested with a TI83822I.
Acked-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/net/phy/dp83848.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 800b39f..320d0dc 100644
--- a/drivers/net/phy/dp83848.c
+++ b/drivers/net/phy/dp83848.c
@@ -88,7 +88,9 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
.phy_id = _id, \
.phy_id_mask = 0xfffffff0, \
.name = _name, \
- .features = PHY_BASIC_FEATURES, \
+ .features = (PHY_BASIC_FEATURES | \
+ SUPPORTED_Pause | \
+ SUPPORTED_Asym_Pause), \
.flags = PHY_HAS_INTERRUPT, \
\
.soft_reset = genphy_soft_reset, \
--
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] net: phy: dp83848: Support ethernet pause frames
2016-12-02 14:57 ` [PATCH v2] " Jesper Nilsson
@ 2016-12-05 18:14 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-12-05 18:14 UTC (permalink / raw)
To: jesper.nilsson; +Cc: f.fainelli, rogerq, afd, dmurphy, netdev, linux-kernel
From: Jesper Nilsson <jesper.nilsson@axis.com>
Date: Fri, 2 Dec 2016 15:57:49 +0100
> According to the documentation, the PHYs supported by this driver
> can also support pause frames. Announce this to be so.
> Tested with a TI83822I.
>
> Acked-by: Andrew F. Davis <afd@ti.com>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-05 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-02 14:22 [PATCH] net: phy: dp83848: Support ethernet pause frames Jesper Nilsson
2016-12-02 14:35 ` Andrew F. Davis
2016-12-02 14:52 ` Jesper Nilsson
2016-12-02 14:57 ` [PATCH v2] " Jesper Nilsson
2016-12-05 18:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).