* [PATCH 1/1] atm: fix improper return value
@ 2016-12-04 5:45 Pan Bian
2016-12-05 19:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2016-12-04 5:45 UTC (permalink / raw)
To: Chas Williams, linux-atm-general, netdev; +Cc: linux-kernel, Pan Bian
From: Pan Bian <bianpan2016@163.com>
It returns variable "error" when ioremap_nocache() returns a NULL
pointer. The value of "error" is 0 then, which will mislead the callers
to believe that there is no error. This patch fixes the bug, returning
"-ENOMEM".
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/atm/eni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index f2aaf9e..40c2d56 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1727,7 +1727,7 @@ static int eni_do_init(struct atm_dev *dev)
printk("\n");
printk(KERN_ERR DEV_LABEL "(itf %d): can't set up page "
"mapping\n",dev->number);
- return error;
+ return -ENOMEM;
}
eni_dev->ioaddr = base;
eni_dev->base_diff = real_base - (unsigned long) base;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] atm: fix improper return value
2016-12-04 5:45 [PATCH 1/1] atm: fix improper return value Pan Bian
@ 2016-12-05 19:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-12-05 19:53 UTC (permalink / raw)
To: bianpan201603
Cc: 3chas3, linux-atm-general, netdev, linux-kernel, bianpan2016
From: Pan Bian <bianpan201603@163.com>
Date: Sun, 4 Dec 2016 13:45:15 +0800
> From: Pan Bian <bianpan2016@163.com>
>
> It returns variable "error" when ioremap_nocache() returns a NULL
> pointer. The value of "error" is 0 then, which will mislead the callers
> to believe that there is no error. This patch fixes the bug, returning
> "-ENOMEM".
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-05 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-04 5:45 [PATCH 1/1] atm: fix improper return value Pan Bian
2016-12-05 19:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).