From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, kamalh@mellanox.com
Subject: Re: [PATCH net 1/6] net/mlx5: Verify module parameters
Date: Mon, 05 Dec 2016 15:05:39 -0500 (EST) [thread overview]
Message-ID: <20161205.150539.1019585301109119643.davem@davemloft.net> (raw)
In-Reply-To: <1480848976-6797-2-git-send-email-saeedm@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Sun, 4 Dec 2016 12:56:11 +0200
> +static uint prof_sel = MLX5_DEFAULT_PROF;
Please do not use type shorthands such as "uint", always expand
fully "unsigned int".
Thanks.
next prev parent reply other threads:[~2016-12-05 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 10:56 [PATCH net 0/6] Mellanox 100G mlx5 fixes 2016-12-04 Saeed Mahameed
2016-12-04 10:56 ` [PATCH net 1/6] net/mlx5: Verify module parameters Saeed Mahameed
2016-12-05 20:05 ` David Miller [this message]
2016-12-04 10:56 ` [PATCH net 2/6] net/mlx5: Remove duplicate pci dev name print Saeed Mahameed
2016-12-04 10:56 ` [PATCH net 3/6] net/mlx5: Fix query ISSI flow Saeed Mahameed
2016-12-04 10:56 ` [PATCH net 4/6] net/mlx5e: Don't notify HW when filling the edge of ICO SQ Saeed Mahameed
2016-12-04 10:56 ` [PATCH net 5/6] net/mlx5e: Don't flush SQ on error Saeed Mahameed
2016-12-04 10:56 ` [PATCH net 6/6] net/mlx5e: Change the SQ/RQ operational state to positive logic Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205.150539.1019585301109119643.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kamalh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).