From: Stefan Eichenberger <eichest@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations
Date: Mon, 5 Dec 2016 22:04:39 +0100 [thread overview]
Message-ID: <20161205210439.GA6038@eichest-notebook> (raw)
In-Reply-To: <20161205162703.22567-5-vivien.didelot@savoirfairelinux.com>
Hi Vivien,
On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote:
> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = {
> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port,
> .g1_set_egress_port = mv88e6095_g1_set_egress_port,
> .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu,
> + .ppu_enable = mv88e6185_g1_ppu_enable,
> + .ppu_disable = mv88e6185_g1_ppu_disable,
> .reset = mv88e6185_g1_reset,
> };
The mv88e6097 should use the indirect access to the phys, bit 14 in g1
control is marked as reserved. They write in the datasheet that
disabling the PPU is still supported but indirect access via g2 should
be used because disabling the PPU is no longer recommended.
Best regards,
Stefan
next prev parent reply other threads:[~2016-12-05 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 16:26 [PATCH v2 net-next v2 0/4] net: dsa: mv88e6xxx: rework reset and PPU code Vivien Didelot
2016-12-05 16:27 ` [PATCH v2 net-next v2 1/4] net: dsa: mv88e6xxx: add helper to disable ports Vivien Didelot
2016-12-05 16:27 ` [PATCH v2 net-next v2 2/4] net: dsa: mv88e6xxx: add helper to hardware reset Vivien Didelot
2016-12-05 16:27 ` [PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation Vivien Didelot
2016-12-05 21:24 ` Stefan Eichenberger
2016-12-05 16:27 ` [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations Vivien Didelot
2016-12-05 21:04 ` Stefan Eichenberger [this message]
2016-12-05 22:18 ` Vivien Didelot
2016-12-06 12:27 ` Stefan Eichenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205210439.GA6038@eichest-notebook \
--to=eichest@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).