From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: cxdx2006@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, feng.deng@cortina-access.com
Subject: Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust
Date: Tue, 06 Dec 2016 09:32:46 -0500 (EST) [thread overview]
Message-ID: <20161206.093246.1063828677061160197.davem@davemloft.net> (raw)
In-Reply-To: <20161206123225.GK1984@nanopsycho>
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 6 Dec 2016 13:32:25 +0100
> Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2006@gmail.com wrote:
>>From: Feng Deng<cxdx2006@gmail.com>
>>
>>1.add judgement to make sure switchdev_port_vlan_fill() could
>> return right, even when switchdev_port_vlan_dump_put() failed ,
>> which will make switchdev_port_vlan_fill() more robust
>>2.add proper return vlaue at the end of the switchdev_port_vlan_fill()
>>
>>Signed-off-by: Feng Deng <feng.deng@cortina-access.com>
>
> Please don't send patches like this. You are wasting everyone's time.
+1
prev parent reply other threads:[~2016-12-06 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEX1niU24TLaRff+TMPu4ek4vT=R2mv9yaE6j1W1ZsFYh99QGg@mail.gmail.com>
2016-12-06 12:32 ` [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust Jiri Pirko
2016-12-06 14:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206.093246.1063828677061160197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cxdx2006@gmail.com \
--cc=feng.deng@cortina-access.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).