From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, f.fainelli@gmail.com,
andrew@lunn.ch, eichest@gmail.com, richardcochran@gmail.com
Subject: Re: [PATCH v3 net-next v3 0/4] net: dsa: mv88e6xxx: rework reset and PPU code
Date: Tue, 06 Dec 2016 11:33:44 -0500 (EST) [thread overview]
Message-ID: <20161206.113344.184595713713966514.davem@davemloft.net> (raw)
In-Reply-To: <20161205223028.20308-1-vivien.didelot@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon, 5 Dec 2016 17:30:24 -0500
> Old Marvell chips (like 88E6060) don't have a PHY Polling Unit (PPU).
>
> Next chips (like 88E6185) have a PPU, which has exclusive access to the
> PHY registers, thus must be disabled before access.
>
> Newer chips (like 88E6352) have an indirect mechanism to access the PHY
> registers whenever, thus loose control over the PPU (always enabled).
>
> Here's a summary:
>
> Model | PPU? | Has PPU ctrl? | PPU state readable? | PHY access
> ----- | ---- | -------------- | ------------------- | ----------
> 6060 | no | no | no | direct
> 6185 | yes | yes, PPUEn bit | yes, PPUState 2-bit | direct w/ PPU dis.
> 6352 | yes | no | yes, PPUState 1-bit | indirect
> 6390 | yes | no | yes, InitState bit | indirect
>
> Depending on the PPU control, a switch may have to restart the PPU when
> resetting the switch. Once the switch is reset, we must wait for the PPU
> state to be active polling again before accessing the registers.
>
> For that purpose, add new operations to the chips to enable/disable the
> PPU, and execute software reset. With these new ops in place, rework the
> switch reset code and finally get rid of the MV88E6XXX_FLAG_PPU* flags.
Series applied, thanks Vivien.
And thanks for the detailed, informative, header postings like this one.
prev parent reply other threads:[~2016-12-06 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 22:30 [PATCH v3 net-next v3 0/4] net: dsa: mv88e6xxx: rework reset and PPU code Vivien Didelot
2016-12-05 22:30 ` [PATCH v3 net-next v3 1/4] net: dsa: mv88e6xxx: add helper to disable ports Vivien Didelot
2016-12-05 22:30 ` [PATCH v3 net-next v3 2/4] net: dsa: mv88e6xxx: add helper to hardware reset Vivien Didelot
2016-12-05 22:30 ` [PATCH v3 net-next v3 3/4] net: dsa: mv88e6xxx: add a soft reset operation Vivien Didelot
2016-12-05 22:30 ` [PATCH v3 net-next v3 4/4] net: dsa: mv88e6xxx: add PPU operations Vivien Didelot
2016-12-06 16:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206.113344.184595713713966514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=eichest@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).