From: David Miller <davem@davemloft.net>
To: alex.g@adaptrum.com
Cc: mugunthanvnm@ti.com, grygorii.strashko@ti.com,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gokhan@adaptrum.com
Subject: Re: [PATCH] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links
Date: Tue, 06 Dec 2016 11:36:30 -0500 (EST) [thread overview]
Message-ID: <20161206.113630.1454582039498444818.davem@davemloft.net> (raw)
In-Reply-To: <1480988033-16535-1-git-send-email-alex.g@adaptrum.com>
From: Alexandru Gagniuc <alex.g@adaptrum.com>
Date: Mon, 5 Dec 2016 17:33:53 -0800
> Support for setting the RGMII_IDMODE bit was added in commit:
> "drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay"
> However, that commit did not add the symmetrical clearing of the bit
> by way of setting it in "mask". Add it here.
>
> Note that the documentation marks clearing this bit as "reserved",
> however, according to TI, support for delaying the clock does exist in
> the MAC, although it is not officially supported.
> We tested this on a board with an RGMII to RGMII link that will not
> work unless this bit is cleared.
>
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
Commits must be referenced by both short-form SHA1-ID as well as
the commit header text.
And since this change is fixing that commit, you should also provide
a proper "Fixes: " tag on the line right before your signoff.
Thanks.
next prev parent reply other threads:[~2016-12-06 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 1:33 [PATCH] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links Alexandru Gagniuc
2016-12-06 16:36 ` David Miller [this message]
2016-12-06 18:56 ` Alex
2016-12-06 18:56 ` [PATCH v2] " Alexandru Gagniuc
2016-12-07 18:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206.113630.1454582039498444818.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.g@adaptrum.com \
--cc=gokhan@adaptrum.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).