From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address() Date: Tue, 06 Dec 2016 11:39:01 -0500 (EST) Message-ID: <20161206.113901.1729006808840379027.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com, jasowang@redhat.com, labbott@redhat.com To: luto@kernel.org Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Andy Lutomirski Date: Mon, 5 Dec 2016 18:10:58 -0800 > With CONFIG_VMAP_STACK=y, virtnet_set_mac_address() can be passed a > pointer to the stack and it will OOPS. Copy the address to the heap > to prevent the crash. > > Cc: Michael S. Tsirkin > Cc: Jason Wang > Cc: Laura Abbott > Reported-by: zbyszek@in.waw.pl > Signed-off-by: Andy Lutomirski Applied, thanks.