From: David Miller <davem@davemloft.net>
To: rvatsavayi@caviumnetworks.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@caviumnetworks.com,
derek.chickles@caviumnetworks.com,
satananda.burla@caviumnetworks.com,
felix.manlunas@caviumnetworks.com
Subject: Re: [PATCH net-next V2 6/7] liquidio CN23XX: VF TX buffers
Date: Tue, 06 Dec 2016 21:50:15 -0500 (EST) [thread overview]
Message-ID: <20161206.215015.600446190668658794.davem@davemloft.net> (raw)
In-Reply-To: <1481058367-3937-7-git-send-email-rvatsavayi@caviumnetworks.com>
From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Date: Tue, 6 Dec 2016 13:06:06 -0800
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> index cf80722..ce5cdcd 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> @@ -270,6 +270,19 @@ static void start_txq(struct net_device *netdev)
> }
>
> /**
> + * \brief Wake a queue
> + * @param netdev network device
> + * @param q which queue to wake
> + */
> +static inline void wake_q(struct net_device *netdev, int q)
...
> +static inline int skb_iq(struct lio *lio, struct sk_buff *skb)
...
> +static inline int check_txq_state(struct lio *lio, struct sk_buff *skb)
Please do not mark functions inline in foo.c files, let the compiler
decide.
next prev parent reply other threads:[~2016-12-07 2:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 21:06 [PATCH net-next V2 0/7] liquidio VF data path Raghu Vatsavayi
2016-12-06 21:06 ` [PATCH net-next V2 1/7] liquidio CN23XX: VF offload features Raghu Vatsavayi
2016-12-06 21:06 ` [PATCH net-next V2 2/7] liquidio CN23XX: VF link status Raghu Vatsavayi
2016-12-06 21:06 ` [PATCH net-next V2 3/7] liquidio CN23XX: VF mac address Raghu Vatsavayi
2016-12-06 21:06 ` [PATCH net-next V2 4/7] liquidio CN23XX: VF scatter gather lists Raghu Vatsavayi
2016-12-06 21:06 ` [PATCH net-next V2 5/7] liquidio CN23XX: VF xmit Raghu Vatsavayi
2016-12-06 21:06 ` [PATCH net-next V2 6/7] liquidio CN23XX: VF TX buffers Raghu Vatsavayi
2016-12-07 2:50 ` David Miller [this message]
2016-12-06 21:06 ` [PATCH net-next V2 7/7] liquidio VF rx data and ctl path Raghu Vatsavayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206.215015.600446190668658794.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@caviumnetworks.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=rvatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).