From: Jiri Pirko <jiri@resnulli.us>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Roi Dayan <roid@mellanox.com>,
Hadar Har-Zion <hadarh@mellanox.com>,
Tom Herbert <tom@herbertland.com>
Subject: Re: [PATCH net-next 1/3] net/flow_dissector: Enable matching on flags for TC filter consumers
Date: Tue, 6 Dec 2016 13:43:58 +0100 [thread overview]
Message-ID: <20161206124358.GM1984@nanopsycho> (raw)
In-Reply-To: <1481027579-23195-2-git-send-email-ogerlitz@mellanox.com>
Tue, Dec 06, 2016 at 01:32:57PM CET, ogerlitz@mellanox.com wrote:
>This is a pre-step to allow TC classifiers that makes use of the
>flow-dissector (e.g Flower) to match on flow-dissector flags which
>are located in the control struct.
>
>Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
>---
> include/net/flow_dissector.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
>index c4f3166..a679e6c 100644
>--- a/include/net/flow_dissector.h
>+++ b/include/net/flow_dissector.h
>@@ -154,8 +154,8 @@ struct flow_dissector {
> };
>
> struct flow_keys {
>+#define FLOW_KEYS_HASH_START_FIELD control
> struct flow_dissector_key_control control;
>-#define FLOW_KEYS_HASH_START_FIELD basic
How is this hashing related to cls_flower dissections? What am I
missing?
next prev parent reply other threads:[~2016-12-06 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 12:32 [PATCH net-next 0/3] net/sched: cls_flower: Add support for matching on dissection flags Or Gerlitz
2016-12-06 12:32 ` [PATCH net-next 1/3] net/flow_dissector: Enable matching on flags for TC filter consumers Or Gerlitz
2016-12-06 12:43 ` Jiri Pirko [this message]
2016-12-06 20:51 ` Or Gerlitz
2016-12-06 12:32 ` [PATCH net-next 2/3] net/sched: cls_flower: Add support for matching on flags Or Gerlitz
2016-12-06 12:40 ` Jiri Pirko
2016-12-06 14:02 ` Or Gerlitz
2016-12-06 12:32 ` [PATCH net-next 3/3] net/mlx5e: Offload TC matching on packets being IP fragments Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206124358.GM1984@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roid@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).