From: Stephen Hemminger <stephen@networkplumber.org>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"John W . Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH net-next 0/2] Add ethtool set regs support
Date: Tue, 6 Dec 2016 14:45:09 -0800 [thread overview]
Message-ID: <20161206144509.5365a623@xeon-e3> (raw)
In-Reply-To: <1481063590-7727-1-git-send-email-saeedm@mellanox.com>
On Wed, 7 Dec 2016 00:33:08 +0200
Saeed Mahameed <saeedm@mellanox.com> wrote:
> This simple ethool change will give HW vendors the flexibility to set
> pure HW configurations (not directly related to netdev resources states
> and rings), without the need of vendor proprietary tools and hacks.
The danger is you need to restrict the kernel to only allow setting
safe registers (and this is HW dependent). There are cases like secure
boot where it is expected that even root is not allowed to modify
all memory.
Also supporting closed format of device registers is not in the interest
of promoting open source.
I am not saying I fundamentally disagree with supporting this, but it
is a bigger step than you make it out to be.
next prev parent reply other threads:[~2016-12-06 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 22:33 [PATCH net-next 0/2] Add ethtool set regs support Saeed Mahameed
2016-12-06 22:33 ` [PATCH net-next 1/2] ethtool: Add set regs -D option support Saeed Mahameed
2016-12-06 22:33 ` [PATCH net-next 2/2] net/mlx5e: Add ethtool get/set reg support Saeed Mahameed
2016-12-06 22:45 ` Stephen Hemminger [this message]
2016-12-11 11:56 ` [PATCH net-next 0/2] Add ethtool set regs support Saeed Mahameed
2016-12-07 2:41 ` Andrew Lunn
2016-12-07 2:57 ` David Miller
2016-12-11 12:41 ` Saeed Mahameed
2016-12-11 12:18 ` Saeed Mahameed
2016-12-11 15:22 ` Andrew Lunn
2016-12-12 17:00 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206144509.5365a623@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).