From: David Miller <davem@davemloft.net>
To: alex.g@adaptrum.com
Cc: mugunthanvnm@ti.com, grygorii.strashko@ti.com,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gokhan@adaptrum.com
Subject: Re: [PATCH v2] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links
Date: Wed, 07 Dec 2016 13:12:29 -0500 (EST) [thread overview]
Message-ID: <20161207.131229.1181078063219041475.davem@davemloft.net> (raw)
In-Reply-To: <1481050611-29698-1-git-send-email-alex.g@adaptrum.com>
From: Alexandru Gagniuc <alex.g@adaptrum.com>
Date: Tue, 6 Dec 2016 10:56:51 -0800
> Support for setting the RGMII_IDMODE bit was added in the commit
> referenced below. However, that commit did not add the symmetrical
> clearing of the bit by way of setting it in "mask". Add it here.
>
> Note that the documentation marks clearing this bit as "reserved",
> however, according to TI, support for delaying the clock does exist in
> the MAC, although it is not officially supported.
> We tested this on a board with an RGMII to RGMII link that will not
> work unless this bit is cleared.
>
> Fixes: 0fb26c3063ea ("drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay")
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
Applied.
prev parent reply other threads:[~2016-12-07 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 1:33 [PATCH] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links Alexandru Gagniuc
2016-12-06 16:36 ` David Miller
2016-12-06 18:56 ` Alex
2016-12-06 18:56 ` [PATCH v2] " Alexandru Gagniuc
2016-12-07 18:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207.131229.1181078063219041475.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.g@adaptrum.com \
--cc=gokhan@adaptrum.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).