From: David Miller <davem@davemloft.net>
To: fgao@ikuai8.com
Cc: maheshb@google.com, edumazet@google.com, netdev@vger.kernel.org,
gfree.wind@gmail.com
Subject: Re: [PATCH net-next v3 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu
Date: Wed, 07 Dec 2016 13:22:27 -0500 (EST) [thread overview]
Message-ID: <20161207.132227.1409237486028723978.davem@davemloft.net> (raw)
In-Reply-To: <1481071487-11227-1-git-send-email-fgao@ikuai8.com>
From: fgao@ikuai8.com
Date: Wed, 7 Dec 2016 08:44:47 +0800
> From: Gao Feng <fgao@ikuai8.com>
>
> There are two functions which would free the ipvl_port now. The first
> is ipvlan_port_create. It frees the ipvl_port in the error handler,
> so it could kfree it directly. The second is ipvlan_port_destroy. It
> invokes netdev_rx_handler_unregister which enforces one grace period
> by synchronize_net firstly, so it also could kfree the ipvl_port
> directly and safely.
>
> So it is unnecessary to use kfree_rcu to free ipvl_port.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
Applied.
prev parent reply other threads:[~2016-12-07 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 0:44 [PATCH net-next v3 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu fgao
2016-12-07 18:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207.132227.1409237486028723978.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).