From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, johan@kernel.org,
rmk+kernel@arm.linux.org.uk, andrew@lunn.ch
Subject: Re: [PATCH net] phy: Don't increment MDIO bus refcount unless it's a different owner
Date: Wed, 07 Dec 2016 13:29:59 -0500 (EST) [thread overview]
Message-ID: <20161207.132959.1815674717089613175.davem@davemloft.net> (raw)
In-Reply-To: <20161207045443.26246-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 6 Dec 2016 20:54:43 -0800
> Commit 3e3aaf649416 ("phy: fix mdiobus module safety") fixed the way we
> dealt with MDIO bus module reference count, but sort of introduced a
> regression in that, if an Ethernet driver registers its own MDIO bus
> driver, as is common, we will end up with the Ethernet driver's
> module->refnct set to 1, thus preventing this driver from any removal.
>
> Fix this by comparing the network device's device driver owner against
> the MDIO bus driver owner, and only if they are different, increment the
> MDIO bus module refcount.
>
> Fixes: 3e3aaf649416 ("phy: fix mdiobus module safety")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
next prev parent reply other threads:[~2016-12-07 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 4:54 [PATCH net] phy: Don't increment MDIO bus refcount unless it's a different owner Florian Fainelli
2016-12-07 18:29 ` David Miller [this message]
2016-12-08 16:27 ` Johan Hovold
2016-12-08 16:47 ` Florian Fainelli
2016-12-08 17:01 ` Johan Hovold
2016-12-08 17:54 ` Florian Fainelli
2016-12-09 9:09 ` Madalin-Cristian Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207.132959.1815674717089613175.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=johan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).