From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: Misalignment, MIPS, and ip_hdr(skb)->version Date: Wed, 07 Dec 2016 13:51:27 -0500 (EST) Message-ID: <20161207.135127.789629809982860453.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com, linux-mips@linux-mips.org To: dave.taht@gmail.com Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" List-Id: netdev.vger.kernel.org From: Dave Taht Date: Wed, 7 Dec 2016 10:47:16 -0800 > https://git.lede-project.org/?p=openwrt/source.git;a=blob;f=target/linux/ar71xx/patches-4.4/910-unaligned_access_hacks.patch;h=b4b749e4b9c02a74a9f712a2740d63e554de5c64;hb=ee53a240ac902dc83209008a2671e7fdcf55957a It's so much better to analyze properly where the misalignment comes from and address it at the source, as we have for various cases that trip up Sparc too. Marking structures "packed" is going to kill performance and is not the answer.