From: Andrew Lunn <andrew@lunn.ch>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
"John W . Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH net-next 0/2] Add ethtool set regs support
Date: Wed, 7 Dec 2016 03:41:43 +0100 [thread overview]
Message-ID: <20161207024143.GA655@lunn.ch> (raw)
In-Reply-To: <1481063590-7727-1-git-send-email-saeedm@mellanox.com>
On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote:
> Hi Dave,
>
> This series adds the support for setting device registers from user
> space ethtool.
Is this not the start of allowing binary only drivers in user space?
Do we want this?
> mlx5 driver have registers allowed access list and will check the user
> Request validity before forwarding it to HW registers. Mlx5 will allow only mlx5 specific
> configurations to be set (e.g. Device Diag Counters for HW performance debugging and analysis)
> which has no standard API to access it.
Would it not be better to define an flexible API to do this? We have
lots of HW performance counters for CPUs. Why is it not possible to do
this for a network device?
Andrew
next prev parent reply other threads:[~2016-12-07 2:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 22:33 [PATCH net-next 0/2] Add ethtool set regs support Saeed Mahameed
2016-12-06 22:33 ` [PATCH net-next 1/2] ethtool: Add set regs -D option support Saeed Mahameed
2016-12-06 22:33 ` [PATCH net-next 2/2] net/mlx5e: Add ethtool get/set reg support Saeed Mahameed
2016-12-06 22:45 ` [PATCH net-next 0/2] Add ethtool set regs support Stephen Hemminger
2016-12-11 11:56 ` Saeed Mahameed
2016-12-07 2:41 ` Andrew Lunn [this message]
2016-12-07 2:57 ` David Miller
2016-12-11 12:41 ` Saeed Mahameed
2016-12-11 12:18 ` Saeed Mahameed
2016-12-11 15:22 ` Andrew Lunn
2016-12-12 17:00 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207024143.GA655@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).