From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Date: Wed, 7 Dec 2016 14:14:24 +0300 Message-ID: <20161207111424.GA5507@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Keyur Chudgar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org To: Iyappan Subramanian Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org We never set "slots" in this function. Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame") Signed-off-by: Dan Carpenter --- I copied how slots gets set in xgene_enet_rx_frame(). Static analysis. Not tested. diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 6c7eea8b36af..884a334e82d0 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, return; dev = ndev_to_dev(buf_pool->ndev); + slots = buf_pool->slots - 1; head = buf_pool->head; for (i = 0; i < 4; i++) {