* Re: [PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init
[not found] <1481102158-980-1-git-send-email-volodymyr.bendiuga@westermo.se>
@ 2016-12-07 14:01 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-12-07 14:01 UTC (permalink / raw)
To: Volodymyr Bendiuga; +Cc: vivien.didelot, f.fainelli, netdev, volodymyr.bendiuga
On Wed, Dec 07, 2016 at 10:15:58AM +0100, Volodymyr Bendiuga wrote:
> Some devices, such as the mv88e6097 do have ADDR[0] external and so it
> is possible to configure the device to use SMI address 0x1. Remove the
> restriction, as there are boards using this address.
>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init
@ 2017-01-03 9:49 Volodymyr Bendiuga
2017-01-03 15:02 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Volodymyr Bendiuga @ 2017-01-03 9:49 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, netdev, volodymyr.bendiuga
From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Some devices, such as the mv88e6097 do have ADDR[0] external and so it
is possible to configure the device to use SMI address 0x1. Remove the
restriction, as there are boards using this address.
Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/chip.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 4da379f..173ea97 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -4234,10 +4234,6 @@ static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip)
static int mv88e6xxx_smi_init(struct mv88e6xxx_chip *chip,
struct mii_bus *bus, int sw_addr)
{
- /* ADDR[0] pin is unavailable externally and considered zero */
- if (sw_addr & 0x1)
- return -EINVAL;
-
if (sw_addr == 0)
chip->smi_ops = &mv88e6xxx_smi_single_chip_ops;
else if (mv88e6xxx_has(chip, MV88E6XXX_FLAGS_MULTI_CHIP))
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init
2017-01-03 9:49 Volodymyr Bendiuga
@ 2017-01-03 15:02 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-03 15:02 UTC (permalink / raw)
To: volodymyr.bendiuga
Cc: andrew, vivien.didelot, f.fainelli, netdev, volodymyr.bendiuga
From: Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com>
Date: Tue, 3 Jan 2017 10:49:09 +0100
> From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
>
> Some devices, such as the mv88e6097 do have ADDR[0] external and so it
> is possible to configure the device to use SMI address 0x1. Remove the
> restriction, as there are boards using this address.
>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-03 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1481102158-980-1-git-send-email-volodymyr.bendiuga@westermo.se>
2016-12-07 14:01 ` [PATCH v2 net-next] dsa:mv88e6xxx: allow address 0x1 in smi_init Andrew Lunn
2017-01-03 9:49 Volodymyr Bendiuga
2017-01-03 15:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).