From: David Miller <davem@davemloft.net>
To: tklauser@distanz.ch
Cc: netdev@vger.kernel.org, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, f.fainelli@gmail.com
Subject: Re: [PATCH] net: axienet: Utilize of_get_mac_address()
Date: Thu, 08 Dec 2016 11:34:21 -0500 (EST) [thread overview]
Message-ID: <20161208.113421.1653870087082595146.davem@davemloft.net> (raw)
In-Reply-To: <20161207122529.29508-1-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Wed, 7 Dec 2016 13:25:28 +0100
> Do not open code getting the MAC address exclusively from the
> "local-mac-address" property, but instead use of_get_mac_address()
> which looks up the MAC address using the 3 typical property names.
>
> Also avoid casting away the const qualifier of the return value by
> making axienet_set_mac_address() take a const void* address.
>
> Follows commit b34296a9c047 ("net: ethoc: Utilize
> of_get_mac_address()").
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
next prev parent reply other threads:[~2016-12-08 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 12:25 [PATCH] net: axienet: Utilize of_get_mac_address() Tobias Klauser
2016-12-07 12:25 ` [PATCH] net: ll_temac: " Tobias Klauser
2016-12-08 16:34 ` David Miller
2016-12-07 12:31 ` [PATCH] net: axienet: " Tobias Klauser
2016-12-08 16:34 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-12-07 12:24 Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208.113421.1653870087082595146.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).