* [PATCH] net: ethernet: slicoss: use module_pci_driver()
@ 2016-12-07 13:43 Tobias Klauser
2016-12-07 20:51 ` Lino Sanfilippo
2016-12-08 18:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Tobias Klauser @ 2016-12-07 13:43 UTC (permalink / raw)
To: Lino Sanfilippo; +Cc: netdev
Use module_pci_driver() to get rid of some boilerplate code.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/ethernet/alacritech/slicoss.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index e77ecd5b307c..b9fbd0107008 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -1863,18 +1863,7 @@ static struct pci_driver slic_driver = {
.remove = slic_remove,
};
-static int __init slic_init_module(void)
-{
- return pci_register_driver(&slic_driver);
-}
-
-static void __exit slic_cleanup_module(void)
-{
- pci_unregister_driver(&slic_driver);
-}
-
-module_init(slic_init_module);
-module_exit(slic_cleanup_module);
+module_pci_driver(slic_driver);
MODULE_DESCRIPTION("Alacritech non-accelerated SLIC driver");
MODULE_AUTHOR("Lino Sanfilippo <LinoSanfilippo@gmx.de>");
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: slicoss: use module_pci_driver()
2016-12-07 13:43 [PATCH] net: ethernet: slicoss: use module_pci_driver() Tobias Klauser
@ 2016-12-07 20:51 ` Lino Sanfilippo
2016-12-08 18:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Lino Sanfilippo @ 2016-12-07 20:51 UTC (permalink / raw)
To: Tobias Klauser; +Cc: netdev
Hi Tobias,
On 07.12.2016 14:43, Tobias Klauser wrote:
> Use module_pci_driver() to get rid of some boilerplate code.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index e77ecd5b307c..b9fbd0107008 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -1863,18 +1863,7 @@ static struct pci_driver slic_driver = {
> .remove = slic_remove,
> };
>
> -static int __init slic_init_module(void)
> -{
> - return pci_register_driver(&slic_driver);
> -}
> -
> -static void __exit slic_cleanup_module(void)
> -{
> - pci_unregister_driver(&slic_driver);
> -}
> -
> -module_init(slic_init_module);
> -module_exit(slic_cleanup_module);
> +module_pci_driver(slic_driver);
>
> MODULE_DESCRIPTION("Alacritech non-accelerated SLIC driver");
> MODULE_AUTHOR("Lino Sanfilippo <LinoSanfilippo@gmx.de>");
>
Yes, makes sense.
Acked-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Thanks,
Lino
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: slicoss: use module_pci_driver()
2016-12-07 13:43 [PATCH] net: ethernet: slicoss: use module_pci_driver() Tobias Klauser
2016-12-07 20:51 ` Lino Sanfilippo
@ 2016-12-08 18:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-08 18:01 UTC (permalink / raw)
To: tklauser; +Cc: LinoSanfilippo, netdev
From: Tobias Klauser <tklauser@distanz.ch>
Date: Wed, 7 Dec 2016 14:43:30 +0100
> Use module_pci_driver() to get rid of some boilerplate code.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-08 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-07 13:43 [PATCH] net: ethernet: slicoss: use module_pci_driver() Tobias Klauser
2016-12-07 20:51 ` Lino Sanfilippo
2016-12-08 18:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).