From: David Miller <davem@davemloft.net>
To: hassan.naveed@imgtec.com
Cc: netdev@vger.kernel.org, paul.burton@imgtec.com,
matt.redfearn@imgtec.com, fw@strlen.de, romieu@fr.zoreil.com
Subject: Re: [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems
Date: Thu, 08 Dec 2016 13:29:30 -0500 (EST) [thread overview]
Message-ID: <20161208.132930.657087361052763772.davem@davemloft.net> (raw)
In-Reply-To: <1481133534-26224-1-git-send-email-hassan.naveed@imgtec.com>
From: Hassan Naveed <hassan.naveed@imgtec.com>
Date: Wed, 7 Dec 2016 09:58:54 -0800
> Fix pch_gbe driver for ethernet operations for a big endian CPU.
> Values written to and read from transmit and receive descriptors
> in the pch_gbe driver are byte swapped from the perspective of a
> big endian CPU, since the ethernet controller always operates in
> little endian mode. Rectify this by appropriately byte swapping
> these descriptor field values in the driver software.
>
> Signed-off-by: Hassan Naveed <hassan.naveed@imgtec.com>
> Reviewed-by: Paul Burton <paul.burton@imgtec.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@imgtec.com>
As explained by Francois, you need to use the proper endian types in
the descriptor datastructure.
Then please run sparse with endianness checking enabled on the build
of the driver.
prev parent reply other threads:[~2016-12-08 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 17:58 [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems Hassan Naveed
2016-12-07 22:05 ` Francois Romieu
2016-12-08 18:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208.132930.657087361052763772.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hassan.naveed@imgtec.com \
--cc=matt.redfearn@imgtec.com \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@imgtec.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).