From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next] net: do not read sk_drops if application does not care
Date: Thu, 08 Dec 2016 13:31:24 -0500 (EST) [thread overview]
Message-ID: <20161208.133124.1404435790534805233.davem@davemloft.net> (raw)
In-Reply-To: <1481133936.4930.51.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 07 Dec 2016 10:05:36 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> sk_drops can be an often written field, do not read it unless
> application showed interest.
>
> Note that sk_drops can be read via inet_diag, so applications
> can avoid getting this info from every received packet.
>
> In the future, 'reading' sk_drops might require folding per node or per
> cpu fields, and thus become even more expensive than today.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2016-12-08 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 18:05 [PATCH net-next] net: do not read sk_drops if application does not care Eric Dumazet
2016-12-08 18:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208.133124.1404435790534805233.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).