From: Pavel Machek <pavel@ucw.cz>
To: Jie Deng <Jie.Deng1@synopsys.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
CARLOS.PALMINHA@synopsys.com, lars.persson@axis.com,
thomas.lendacky@amd.com, peppe.cavallaro@st.com,
Joao.Pinto@synopsys.com
Subject: Re: [PATCH net-next 2/2] net: ethernet: Initial driver for Synopsys DWC XLGMAC
Date: Thu, 8 Dec 2016 22:57:12 +0100 [thread overview]
Message-ID: <20161208215712.GB12472@amd> (raw)
In-Reply-To: <bea5ea07-cbab-35fe-434c-1cfcb96225ef@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 2399 bytes --]
On Thu 2016-12-08 13:58:47, Jie Deng wrote:
>
>
> On 2016/12/7 17:48, Pavel Machek wrote:
> > Hi!
> >
> >> This patch provides the initial driver for 25/40/50/100 GbE
> >> devices using Synopsys DWC Enterprise Ethernet (XLGMAC)
> >>
> >> Signed-off-by: Jie Deng <jiedeng@synopsys.com>
> > I trust this is different hardware from stmmac?
> Yes, different hardware. Currently, Synopsys has several Ethernet IP cores. But
> drivers for these hardwares are scattered in different places. I really hope
> that they can be centralized into driver/net/ethernet/synopsys for maintenance.
> This makes things easy for others to find the corresponding drivers.
> - QoS
> drivers/net/ethernet/synopsys/dwc_eth_qos.c
> drivers/net/ethernet/stmicro/stmmac/
> - XGMAC
> driver/net/ethernet/amd/xgbe/
> - XLGMAC
> No driver for this hardware in mainline at present.
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 331f6af..738f818 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -10639,6 +10639,12 @@ S: Supported
> >> F: Documentation/devicetree/bindings/net/snps,dwc-qos-ethernet.txt
> >> F: drivers/net/ethernet/synopsys/dwc_eth_qos.c
> >>
> >> +SYNOPSYS DESIGNWARE ENTERPRISE ETHERNET (XLGMAC) DRIVER
> >> +M: jiedeng <jiedeng@synopsys.com>
> > Jie Deng here?
> Oh, should be Jie Deng here. Thank you!
> >
> >> @@ -0,0 +1,228 @@
> >> +/*
> >> + * Synopsys DesignWare Ethernet Driver
> > Your patch title names hardware differently...?
> Yes, currently, it should be XLGMAC driver. I extracted the parts can be shared
> for different Synopsys IPs.
>
> The XLGMAC driver can be divided into three parts
>
> - The DWC ethernet core layer (DWC ECL):
> Currently, it supports XLGMAC. But I think this part can be shared for different
> Synopsys IPs.
>
> - The DWC MAC HW adapter layer (DWC MHAL):
> This part was designed to include special support for a specific MAC IP.
> Currently, XLGMAC, and I think we can add
> something to support XGMAC and QoS in the future.
>
> - The glue adapter layer (GAL)
Ok, thanks for description. Hopefully it can be merged in a way that
is not too confusing...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-12-08 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 3:57 [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC Jie Deng
2016-12-07 3:57 ` [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII Jie Deng
2016-12-08 22:15 ` Florian Fainelli
2016-12-09 5:19 ` Jie Deng
2016-12-09 16:39 ` Andrew Lunn
2016-12-10 2:16 ` Jie Deng
2016-12-07 3:57 ` [PATCH net-next 2/2] net: ethernet: Initial driver for Synopsys DWC XLGMAC Jie Deng
2016-12-07 9:48 ` Pavel Machek
[not found] ` <bea5ea07-cbab-35fe-434c-1cfcb96225ef@synopsys.com>
2016-12-08 21:57 ` Pavel Machek [this message]
2016-12-12 8:26 ` kbuild test robot
2016-12-08 15:59 ` [PATCH net-next 0/2] " Alexandre Torgue
2016-12-09 4:47 ` Jie Deng
2016-12-09 15:15 ` Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208215712.GB12472@amd \
--to=pavel@ucw.cz \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jie.Deng1@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).