From: Richard Cochran <richardcochran@gmail.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
Wingman Kwok <w-kwok2@ti.com>
Subject: Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH
Date: Fri, 9 Dec 2016 09:50:37 +0100 [thread overview]
Message-ID: <20161209085037.GA16009@localhost.localdomain> (raw)
In-Reply-To: <58eea45f-b8fe-6892-e784-b41638c62fd8@ti.com>
On Thu, Dec 08, 2016 at 01:04:11PM -0600, Grygorii Strashko wrote:
> huh. Seems this is not really good idea, because MISC Irq will be
> triggered for *any* CPTS event and there is no way to enable it just for
> HW_TS_PUSH.
So what? That is not a problem.
> So, this doesn't work will with current code for RX/TX timestamping
> (which uses polling mode).
Why doesn't it work?
> + runtime overhead in net RX/TX caused by
> triggering more interrupts.
This is not relevant. Without HW_TS_PUSH, there is no need for
enabling the interrupt simply because we don't need it. Now, with
HW_TS_PUSH, we do need it.
> May be, overflow check/polling timeout can be made configurable (module parameter).
No, it should just work without any user space fiddling.
I getting a bit tired of your half-baked implementations of the
ancillary clock functions. Either do it right, or just leave it
unsupported.
Thanks,
Richard
next prev parent reply other threads:[~2016-12-09 8:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 23:04 [PATCH 0/6] net: ethernet: ti: cpts: update and enable support on keystone 2 socs Grygorii Strashko
2016-11-28 23:04 ` [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts Grygorii Strashko
2016-11-30 9:44 ` Richard Cochran
[not found] ` <20161130094441.GB28680-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-11-30 17:31 ` Grygorii Strashko
2016-11-30 18:22 ` Richard Cochran
2016-12-05 14:49 ` Rob Herring
2016-12-05 18:25 ` Grygorii Strashko
2016-12-05 19:30 ` Richard Cochran
2016-11-28 23:04 ` [PATCH 2/6] net: ethernet: ti: cpts: add support for ext rftclk selection Grygorii Strashko
[not found] ` <20161128230428.6872-3-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-11-30 9:56 ` Richard Cochran
[not found] ` <20161130095632.GC28680-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-11-30 17:35 ` Grygorii Strashko
2016-12-06 19:39 ` Grygorii Strashko
2016-12-06 20:25 ` Richard Cochran
[not found] ` <20161206202558.GB23605-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-12-06 20:40 ` Grygorii Strashko
2016-12-09 0:47 ` Stephen Boyd
[not found] ` <20161209004745.GJ5423-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-12-09 23:29 ` Grygorii Strashko
2016-12-05 14:51 ` Rob Herring
2016-11-28 23:04 ` [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH Grygorii Strashko
[not found] ` <20161128230428.6872-4-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-11-30 10:19 ` Richard Cochran
2016-11-30 11:08 ` Jan Lübbe
2016-11-30 20:15 ` Grygorii Strashko
2016-12-03 23:21 ` Richard Cochran
2016-12-08 19:04 ` Grygorii Strashko
2016-12-09 8:50 ` Richard Cochran [this message]
2016-11-28 23:04 ` [PATCH 4/6] net: ethernet: ti: cpts: add ptp pps support Grygorii Strashko
2016-11-30 10:05 ` Richard Cochran
[not found] ` <20161130100519.GD28680-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-12-06 18:08 ` Richard Cochran
2016-12-06 20:43 ` Grygorii Strashko
2016-11-30 11:01 ` Jan Lübbe
2016-11-30 18:45 ` Richard Cochran
2016-11-30 20:43 ` Grygorii Strashko
2016-11-30 22:17 ` Richard Cochran
2016-12-02 9:58 ` Richard Cochran
2016-12-02 17:58 ` Grygorii Strashko
[not found] ` <bfbebf2d-d057-6a21-845c-48f0a9ab0404-l0cyMroinI0@public.gmane.org>
2016-12-02 19:28 ` Richard Cochran
[not found] ` <20161128230428.6872-1-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-11-28 23:04 ` [PATCH 5/6] ARM: keystone: dts: fix netcp clocks and add names Grygorii Strashko
2016-11-28 23:04 ` [PATCH 6/6] ARM: dts: keystone: enable time synchronization (cpts) submodule Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209085037.GA16009@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).