* sanity checking iov_iter patches
@ 2016-12-15 6:23 Al Viro
2016-12-15 9:00 ` Jesper Dangaard Brouer
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2016-12-15 6:23 UTC (permalink / raw)
To: netdev; +Cc: David Miller
Some of the vfs.git#work.iov_iter stuff touches net/*; basically,
there are several missing primitives (copy_from_iter_full(), etc.) for
"try to copy, tell whether it has copied the full amount requested and
advance the iterator only in case of success". Most of the callers were
actually doing just that (see e.g. skb_add_data() and friends) and while
nothing in the current kernel cares whether we advance ->msg_iter on
failure, it's much more consistent semantics.
If anybody has objections to that stuff (in linux-next, or in
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git#work.iov_iter),
or thinks that some of that should go via net-next.git, yell and I'll
drop the bits in question. If not, to Linus it all goes...
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sanity checking iov_iter patches
2016-12-15 6:23 sanity checking iov_iter patches Al Viro
@ 2016-12-15 9:00 ` Jesper Dangaard Brouer
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2016-12-15 9:00 UTC (permalink / raw)
To: Al Viro; +Cc: brouer, netdev, David Miller
On Thu, 15 Dec 2016 06:23:05 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> Some of the vfs.git#work.iov_iter stuff touches net/*; basically,
> there are several missing primitives (copy_from_iter_full(), etc.) for
> "try to copy, tell whether it has copied the full amount requested and
> advance the iterator only in case of success". Most of the callers were
> actually doing just that (see e.g. skb_add_data() and friends) and while
> nothing in the current kernel cares whether we advance ->msg_iter on
> failure, it's much more consistent semantics.
>
> If anybody has objections to that stuff (in linux-next, or in
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git#work.iov_iter),
> or thinks that some of that should go via net-next.git, yell and I'll
> drop the bits in question. If not, to Linus it all goes...
Just some links to make it quicker for people see the three patches:
http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/log/?h=work.iov_iter
Patches:
http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.iov_iter&id=cbbd26b8b1a
http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.iov_iter&id=15e6cb46c9b
http://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/commit/?h=work.iov_iter&id=0b62fca2623
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-15 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-15 6:23 sanity checking iov_iter patches Al Viro
2016-12-15 9:00 ` Jesper Dangaard Brouer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).