From: Tobias Klauser <tklauser@distanz.ch>
To: shakya.das@samsung.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
shakya89.das@gmail.com, vidushi.koul@samsung.com
Subject: Re: [PATCH] net: ipv4: tcp_offload: check segs for NULL
Date: Thu, 15 Dec 2016 14:43:17 +0100 [thread overview]
Message-ID: <20161215134315.GE5816@distanz.ch> (raw)
In-Reply-To: <1481791661-21670-1-git-send-email-shakya.das@samsung.com>
On 2016-12-15 at 09:47:41 +0100, shakya.das@samsung.com <shakya.das@samsung.com> wrote:
> From: Shakya Sundar Das <shakya.das@samsung.com>
>
> This patch will check segs for being NULL in tcp_gso_segment()
> before calling skb_shinfo(segs) from skb_is_gso(segs), otherwise
> kernel can run into a NULL-pointer dereference.
How can segs ever be NULL here? skb_segment() will always either return
an skb or an ERR_PTR(err).
next prev parent reply other threads:[~2016-12-15 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 8:47 [PATCH] net: ipv4: tcp_offload: check segs for NULL shakya.das
2016-12-15 13:43 ` Tobias Klauser [this message]
2016-12-16 3:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161215134315.GE5816@distanz.ch \
--to=tklauser@distanz.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shakya.das@samsung.com \
--cc=shakya89.das@gmail.com \
--cc=vidushi.koul@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox