From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vishwanathapura, Niranjana" Subject: Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC) Date: Thu, 15 Dec 2016 18:47:48 -0800 Message-ID: <20161216024748.GB90951@knc-06.sc.intel.com> References: <1481788782-89964-1-git-send-email-niranjana.vishwanathapura@intel.com> <20161215091226.GC811@mtr-leonro.local> <20161215145212.GA29116@phlsvsds.ph.intel.com> <380b05bf-a18e-1f20-7e8e-10b61f77dec7@redhat.com> <20161215170713.GD3264@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: Doug Ledford , "ira.weiny" , Leon Romanovsky , Jeff Kirsher , "David S. Miller" , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org To: Jason Gunthorpe Return-path: Content-Disposition: inline In-Reply-To: <20161215170713.GD3264-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Dec 15, 2016 at 10:07:13AM -0700, Jason Gunthorpe wrote: >On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > >> 1) Since your intent is to make this work with multiple versions of the >> hfi drivers, I disagree with Jason that just because there is only one >> driver today that we should keep it simple. Design it right from the >> beginning of multi driver is your intent is, IMO, a better way to go. >> You'll work out the bugs in the initial implementation and when it comes >> time to add the second driver, things will go much more smoothly. > >If that is your position then this should be a straight up IB ULP that >works with any IB hardware. > >There is nothing HFI specific about it except for the >micro-optimization of pushing packets via SDMA instead of post_send, >and that same micro optimization probably applies to ipoib. > Responded on the other thread. As mentioned, there are differences between ipoib and hfi_vnic interface. For hfi_vnic, we need simple interface as defined in the include/rdma/opa_hfi.h that represents HW to put/get already encapsulated OPA packets. >In other words, lets see the first version as a straight ULP with no >special HFI hooks, then we can discuss how best to micro optimize it >for HFI SDMA. > As mentioned in other thread, that would be putting hfi_vnic_ctrl_ops in ib_device structure. Niranjana >Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html