From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: [PATCH net] qed: fix old-style function definition Date: Fri, 16 Dec 2016 09:47:41 +0100 Message-ID: <20161216084808.1815139-1-arnd@arndb.de> Cc: Arnd Bergmann , Arun Easi , Hannes Reinecke , "David S. Miller" , Johannes Thumshirn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Yuval Mintz , Ariel Elior , everest-linux-l2@cavium.com Return-path: Received: from mout.kundenserver.de ([212.227.126.131]:50020 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbcLPIs0 (ORCPT ); Fri, 16 Dec 2016 03:48:26 -0500 Sender: netdev-owner@vger.kernel.org List-ID: The newly added file causes a harmless warning, with "make W=1": drivers/net/ethernet/qlogic/qed/qed_iscsi.c: In function 'qed_get_iscsi_ops': drivers/net/ethernet/qlogic/qed/qed_iscsi.c:1268:29: warning: old-style function definition [-Wold-style-definition] This makes it a proper prototype. Fixes: fc831825f99e ("qed: Add support for hardware offloaded iSCSI.") Signed-off-by: Arnd Bergmann --- I only saw this after it was already merged for v4.10 drivers/net/ethernet/qlogic/qed/qed_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_iscsi.c b/drivers/net/ethernet/qlogic/qed/qed_iscsi.c index 00efb1c4c57e..17a70122df05 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_iscsi.c +++ b/drivers/net/ethernet/qlogic/qed/qed_iscsi.c @@ -1265,7 +1265,7 @@ static const struct qed_iscsi_ops qed_iscsi_ops_pass = { .get_stats = &qed_iscsi_stats, }; -const struct qed_iscsi_ops *qed_get_iscsi_ops() +const struct qed_iscsi_ops *qed_get_iscsi_ops(void) { return &qed_iscsi_ops_pass; } -- 2.9.0