From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Daniel Mack <daniel@zonque.org>
Cc: ast@fb.com, daniel@iogearbox.net, netdev@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu
Date: Fri, 16 Dec 2016 10:20:37 -0800 [thread overview]
Message-ID: <20161216182036.GB80546@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <20161215095321.10571-1-daniel@zonque.org>
On Thu, Dec 15, 2016 at 10:53:21AM +0100, Daniel Mack wrote:
> The member 'effective' in 'struct cgroup_bpf' is protected by RCU.
> Annotate it accordingly to squelch a sparse warning.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Acked-by: Alexei Starovoitov <ast@kernel.org>
was only wondering whether this is really needed for net or can wait till net-next.
> ---
> include/linux/bpf-cgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h
> index 7b6e5d1..92bc89a 100644
> --- a/include/linux/bpf-cgroup.h
> +++ b/include/linux/bpf-cgroup.h
> @@ -20,7 +20,7 @@ struct cgroup_bpf {
> * when this cgroup is accessed.
> */
> struct bpf_prog *prog[MAX_BPF_ATTACH_TYPE];
> - struct bpf_prog *effective[MAX_BPF_ATTACH_TYPE];
> + struct bpf_prog __rcu *effective[MAX_BPF_ATTACH_TYPE];
> };
>
> void cgroup_bpf_put(struct cgroup *cgrp);
> --
> 2.9.3
>
next prev parent reply other threads:[~2016-12-16 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 9:53 [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu Daniel Mack
2016-12-16 18:20 ` Alexei Starovoitov [this message]
2016-12-17 16:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216182036.GB80546@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox