From: David Miller <davem@davemloft.net>
To: manuel.bessler@sensus.com
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH v3 net] r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected
Date: Sat, 17 Dec 2016 21:36:30 -0500 (EST) [thread overview]
Message-ID: <20161217.213630.371461596447265670.davem@davemloft.net> (raw)
In-Reply-To: <1481860500-25117-1-git-send-email-manuel.bessler@sensus.com>
From: Manuel Bessler <manuel.bessler@sensus.com>
Date: Thu, 15 Dec 2016 22:55:00 -0500
> 'ifconfig eth0 down' makes r6040_close() trigger:
> INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected
>
> Fixed by moving calls to phy_stop(), napi_disable(), netif_stop_queue()
> to outside of the module's private spin_lock_irq block.
>
> Found on a Versalogic Tomcat SBC with a Vortex86 SoC
...
> Signed-off-by: Manuel Bessler <manuel.bessler@sensus.com>
Applied, thanks.
prev parent reply other threads:[~2016-12-18 2:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 17:46 [PATCH net] r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected Manuel Bessler
2016-12-15 18:21 ` [PATCH v2 net] rebased to master Manuel Bessler
2016-12-15 19:59 ` Florian Fainelli
2016-12-16 3:55 ` [PATCH v3 net] r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected Manuel Bessler
2016-12-18 2:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217.213630.371461596447265670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=manuel.bessler@sensus.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox