From: David Miller <davem@davemloft.net>
To: bfolta@cadence.com
Cc: nicolas.ferre@atmel.com, niklas.cassel@axis.com,
alexandre.torgue@st.com, satananda.burla@caviumnetworks.com,
rvatsavayi@caviumnetworks.com, simon.horman@netronome.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rafalo@cadence.com
Subject: Re: [PATCH] net: macb: Applied changes according to review made by Andy Shevchenko.
Date: Wed, 21 Dec 2016 11:08:56 -0500 (EST) [thread overview]
Message-ID: <20161221.110856.890610349232988869.davem@davemloft.net> (raw)
In-Reply-To: <SN1PR0701MB1951B994F86160A24C436F30CC930@SN1PR0701MB1951.namprd07.prod.outlook.com>
From: Bartosz Folta <bfolta@cadence.com>
Date: Wed, 21 Dec 2016 08:53:05 +0000
> This patch is sent in regard to recently applied patch
> Commit 83a77e9ec4150ee4acc635638f7dedd9da523a26
> net: macb: Added PCI wrapper for Platform Driver.
> Andy's review does not appear on mailing lists. I can't reference it.
>
> Signed-off-by: Bartosz Folta <bfolta@cadence.com>
This commit log message and Subject line need a lot of improvement.
You should be saying what exactly you are doing, rather than "someone
said I should do this". The latter gives the reader no information
whatsoever about what the patch is doing.
prev parent reply other threads:[~2016-12-21 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1482309315-582-1-git-send-email-bfolta@cadence.com>
2016-12-21 8:53 ` [PATCH] net: macb: Applied changes according to review made by Andy Shevchenko Bartosz Folta
2016-12-21 16:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221.110856.890610349232988869.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=bfolta@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=niklas.cassel@axis.com \
--cc=rafalo@cadence.com \
--cc=rvatsavayi@caviumnetworks.com \
--cc=satananda.burla@caviumnetworks.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox