From: David Miller <davem@davemloft.net>
To: Joao.Pinto@synopsys.com
Cc: peppe.cavallaro@st.com, hock.leong.kweh@intel.com,
niklas.cassel@axis.com, pavel@ucw.cz,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] stmmac: CSR clock configuration fix
Date: Wed, 21 Dec 2016 13:21:04 -0500 (EST) [thread overview]
Message-ID: <20161221.132104.1026207180067066991.davem@davemloft.net> (raw)
In-Reply-To: <6d4c6d15a60c93a8aef5e3e03b9cd64cdcf232c8.1482232420.git.jpinto@synopsys.com>
From: Joao Pinto <Joao.Pinto@synopsys.com>
Date: Tue, 20 Dec 2016 11:21:47 +0000
> When testing stmmac with my QoS reference design I checked a problem in the
> CSR clock configuration that was impossibilitating the phy discovery, since
> every read operation returned 0x0000ffff. This patch fixes the issue.
>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
This isn't enough.
It looks like various parts of this driver set the mask field
differently.
dwmac1000_core.c and dwmac100_core.c set the mask to be the low bits.
But dwmac4_core.c uses GENMASK(11, 8) which means the mask is a value
which is shifted up already.
So your patch will break chips driven by dwmac4_core.c.
In order for your change to be correct you must consolidate all of
these various pieces to use the same convention.
next prev parent reply other threads:[~2016-12-21 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 11:21 [PATCH] stmmac: CSR clock configuration fix Joao Pinto
2016-12-21 18:21 ` David Miller [this message]
2016-12-22 10:15 ` Joao Pinto
2016-12-22 12:23 ` Joao Pinto
2016-12-22 12:28 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221.132104.1026207180067066991.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=pavel@ucw.cz \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).