From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH net-next 14/27] net: mvpp2: add ip_version field in "struct mvpp2" Date: Wed, 21 Dec 2016 18:04:00 +0100 Message-ID: <20161221180400.27aca37c@free-electrons.com> References: <1482318994-23488-1-git-send-email-thomas.petazzoni@free-electrons.com> <1482318994-23488-15-git-send-email-thomas.petazzoni@free-electrons.com> <20161221170252.GO30952@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Yehuda Yitschak , Jason Cooper , netdev@vger.kernel.org, Hanna Hawa , Nadav Haklai , Gregory Clement , Stefan Chulski , Marcin Wojtas , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth To: Andrew Lunn Return-path: In-Reply-To: <20161221170252.GO30952@lunn.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org Hello, On Wed, 21 Dec 2016 18:02:52 +0100, Andrew Lunn wrote: > On Wed, Dec 21, 2016 at 12:16:21PM +0100, Thomas Petazzoni wrote: > > In preparation to the introduction for the support of PPv2.2 in the > > mvpp2 driver, this commit adds an ip_version field to the struct > > mvpp2 > > When i read this, i was thinking IPv4 vs IPv6. It is a network driver after all. > Could you maybe call this hw_version? Sure, will do. Thanks for the feedback! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com