From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 1/1] tipc: don't send FIN message from connectionless socket Date: Thu, 22 Dec 2016 11:20:57 -0500 (EST) Message-ID: <20161222.112057.1343936871026993835.davem@davemloft.net> References: <1482409349-17081-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, viro@zeniv.linux.org.uk To: jon.maloy@ericsson.com Return-path: In-Reply-To: <1482409349-17081-1-git-send-email-jon.maloy@ericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tipc-discussion-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org From: Jon Maloy Date: Thu, 22 Dec 2016 07:22:29 -0500 > In commit 6f00089c7372 ("tipc: remove SS_DISCONNECTING state") the > check for socket type is in the wrong place, causing a closing socket > to always send out a FIN message even when the socket was never > connected. This is normally harmless, since the destination node for > such messages most often is zero, and the message will be dropped, but > it is still a wrong and confusing behavior. > > We fix this in this commit. > > Reviewed-by: Parthasarathy Bhuvaragan > Signed-off-by: Jon Maloy Applied. ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel