From: David Miller <davem@davemloft.net>
To: thomas.preisner+linux@fau.de
Cc: sergei.shtylyov@cogentembedded.com, dave@thedillows.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel@i4.cs.fau.de, milan.stephan+linux@fau.de
Subject: Re: [PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value
Date: Sat, 24 Dec 2016 19:56:54 -0500 (EST) [thread overview]
Message-ID: <20161224.195654.1632303818126752071.davem@davemloft.net> (raw)
In-Reply-To: <1482625822-19658-2-git-send-email-thomas.preisner+linux@fau.de>
It is never, ever, appropriate to use the same exact Subject: line
text for two different changes.
Someone looking at "git shortlog" has no way to know what is different
between the two changes.
You must put care and time into constructing Subject: lines because
this text is critical for data mining and analysis done by both humans
and machines.
next prev parent reply other threads:[~2016-12-25 0:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 23:00 [PATCH] drivers: net: ethernet: 3com: fix return value Thomas Preisner
2016-12-24 1:05 ` David Dillow
2016-12-24 12:02 ` Thomas Preisner
2016-12-24 12:02 ` [PATCH v2 1/2] " Thomas Preisner
2016-12-24 19:06 ` Sergei Shtylyov
2016-12-25 0:30 ` Thomas Preisner
2016-12-25 0:30 ` [PATCH v3 " Thomas Preisner
2016-12-25 0:56 ` David Miller [this message]
2016-12-25 0:30 ` [PATCH v3 2/2] " Thomas Preisner
2016-12-25 10:07 ` Sergei Shtylyov
2016-12-27 21:17 ` David Dillow
2016-12-30 2:37 ` Thomas Preisner
2016-12-30 2:37 ` [PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix incorrect return values Thomas Preisner
2016-12-30 20:27 ` David Miller
2016-12-30 2:37 ` [PATCH v4 2/2] net: 3com: typhoon: typhoon_init_one: make return values more specific Thomas Preisner
2016-12-30 20:27 ` David Miller
2016-12-27 21:15 ` Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value David Dillow
2016-12-24 12:02 ` [PATCH v2 2/2] " Thomas Preisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161224.195654.1632303818126752071.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave@thedillows.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=milan.stephan+linux@fau.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.preisner+linux@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).