From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org, andreyknvl@google.com
Subject: Re: [PATCH] net: handle no dst on skb in icmp6_send
Date: Tue, 27 Dec 2016 21:36:36 -0500 (EST) [thread overview]
Message-ID: <20161227.213636.1101620491173588415.davem@davemloft.net> (raw)
In-Reply-To: <1481205857.4073547.812616921.223287BE@webmail.messagingengine.com>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Thu, 08 Dec 2016 15:04:17 +0100
> Hello David,
>
> On Mon, Nov 28, 2016, at 22:13, David Miller wrote:
>> From: David Ahern <dsa@cumulusnetworks.com>
>> Date: Sun, 27 Nov 2016 18:52:53 -0800
>>
>> > Andrey reported the following while fuzzing the kernel with syzkaller:
>> ...
>> > icmp6_send / icmpv6_send is invoked for both rx and tx paths. In both
>> > cases the dst->dev should be preferred for determining the L3 domain
>> > if the dst has been set on the skb. Fallback to the skb->dev if it has
>> > not. This covers the case reported here where icmp6_send is invoked on
>> > Rx before the route lookup.
>> >
>> > Fixes: 5d41ce29e ("net: icmp6_send should use dst dev to determine L3 domain")
>> > Reported-by: Andrey Konovalov <andreyknvl@google.com>
>> > Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
>>
>> Applied, thanks David.
>
> could you queue this patch up for stable. You can remotely kill machines
> with this bug.
Sure, queued up, thanks.
prev parent reply other threads:[~2016-12-28 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 2:52 [PATCH] net: handle no dst on skb in icmp6_send David Ahern
2016-11-28 21:13 ` David Miller
2016-12-08 14:04 ` Hannes Frederic Sowa
2016-12-28 2:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227.213636.1101620491173588415.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreyknvl@google.com \
--cc=dsa@cumulusnetworks.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).