From: David Miller <davem@davemloft.net>
To: davej@codemonkey.org.uk
Cc: netdev@vger.kernel.org
Subject: Re: ipv6: remove unnecessary inet6_sk check
Date: Thu, 29 Dec 2016 12:06:09 -0500 (EST) [thread overview]
Message-ID: <20161229.120609.273388969622365315.davem@davemloft.net> (raw)
In-Reply-To: <20161228165318.5afrtlbulsgymc4c@codemonkey.org.uk>
From: Dave Jones <davej@codemonkey.org.uk>
Date: Wed, 28 Dec 2016 11:53:18 -0500
> np is already assigned in the variable declaration of ping_v6_sendmsg.
> At this point, we have already dereferenced np several times, so the
> NULL check is also redundant.
>
> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Applied, thanks Dave.
prev parent reply other threads:[~2016-12-29 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 16:53 ipv6: remove unnecessary inet6_sk check Dave Jones
2016-12-29 17:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229.120609.273388969622365315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).