From: David Miller <davem@davemloft.net>
To: minipli@googlemail.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net] rtnl: stats - add missing netlink message size checks
Date: Thu, 29 Dec 2016 14:06:09 -0500 (EST) [thread overview]
Message-ID: <20161229.140609.389807839111668344.davem@davemloft.net> (raw)
In-Reply-To: <1482943935-18052-1-git-send-email-minipli@googlemail.com>
From: Mathias Krause <minipli@googlemail.com>
Date: Wed, 28 Dec 2016 17:52:15 +0100
> We miss to check if the netlink message is actually big enough to contain
> a struct if_stats_msg.
>
> Add a check to prevent userland from sending us short messages that would
> make us access memory beyond the end of the message.
>
> Fixes: 10c9ead9f3c6 ("rtnetlink: add new RTM_GETSTATS message to dump...")
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
Looks good, applied and queued up for -stable.
prev parent reply other threads:[~2016-12-29 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 16:52 [PATCH net] rtnl: stats - add missing netlink message size checks Mathias Krause
2016-12-29 19:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229.140609.389807839111668344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).