From: David Miller <davem@davemloft.net>
To: sridhar.samudrala@intel.com
Cc: alexander.h.duyck@intel.com, john.r.fastabend@intel.com,
anjali.singhai@intel.com, jakub.kicinski@netronome.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH 2/6] i40e: Introduce VF Port Representator(VFPR) netdevs.
Date: Thu, 29 Dec 2016 21:52:51 -0500 (EST) [thread overview]
Message-ID: <20161229.215251.689242851887487491.davem@davemloft.net> (raw)
In-Reply-To: <1483078863-22026-3-git-send-email-sridhar.samudrala@intel.com>
From: Sridhar Samudrala <sridhar.samudrala@intel.com>
Date: Thu, 29 Dec 2016 22:20:59 -0800
> /* VF resources get allocated during reset */
> i40e_reset_vf(&vfs[i], false);
>
> + if (pf->eswitch_mode == DEVLINK_ESWITCH_MODE_SWITCHDEV)
> + i40e_alloc_vfpr_netdev(&vfs[i], i);
You aren't checking for, and unwinding from, errors signalled
by i40e_alloc_vfpr_netdev().
next prev parent reply other threads:[~2016-12-30 2:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 6:20 [net-next PATCH 0/6] i40e: Add VF port representator support or SR-IOV VFs Sridhar Samudrala
2016-12-30 2:53 ` David Miller
2016-12-30 16:55 ` Samudrala, Sridhar
2016-12-30 6:20 ` [net-next PATCH 1/6] i40e: Introduce devlink interface Sridhar Samudrala
2016-12-30 6:20 ` [net-next PATCH 2/6] i40e: Introduce VF Port Representator(VFPR) netdevs Sridhar Samudrala
2016-12-30 2:52 ` David Miller [this message]
2016-12-30 6:21 ` [net-next PATCH 3/6] i40e: Sync link state between VFs and VFPRs Sridhar Samudrala
2016-12-30 15:43 ` Or Gerlitz
2016-12-30 17:10 ` Samudrala, Sridhar
2016-12-30 6:21 ` [net-next PATCH 5/6] i40e: Add TX and RX support in switchdev mode Sridhar Samudrala
2016-12-30 15:31 ` Or Gerlitz
2016-12-30 17:04 ` Samudrala, Sridhar
2017-01-03 23:03 ` Or Gerlitz
2017-01-04 22:46 ` Samudrala, Sridhar
2017-01-05 11:50 ` Or Gerlitz
2017-01-05 22:32 ` Samudrala, Sridhar
2017-01-06 9:24 ` Or Gerlitz
2016-12-30 6:21 ` [net-next PATCH 6/6] i40e: Add support for exposing VF port statistics via VFPR netdev on the host Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229.215251.689242851887487491.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).