From: Wei Liu <wei.liu2@citrix.com>
To: Mart van Santen <mart@greenhost.nl>
Cc: <netdev@vger.kernel.org>, <wei.liu2@citrix.com>
Subject: Re: [PATCH] vif queue counters from int to long
Date: Thu, 29 Dec 2016 10:47:09 +0000 [thread overview]
Message-ID: <20161229104709.GY28690@citrix.com> (raw)
In-Reply-To: <585D3E23.10509@greenhost.nl>
On Fri, Dec 23, 2016 at 04:09:23PM +0100, Mart van Santen wrote:
>
> Hello,
>
> This patch fixes an issue where counters in the queue have type int,
> while the counters of the vif itself are specified as long. This can
> cause incorrect reporting of tx/rx values of the vif interface.
> More extensively reported on xen-devel mailinglist.
>
Hello,
Please also CC xen-devel@lists.xenproject.org for your future patch(es).
And please note that the most up to date maintainer information should
be used.
Wei.
>
>
> Signed-off-by: Mart van Santen <mart@greenhost.nl>
> --- a/drivers/net/xen-netback/common.h 2016-12-22 15:41:07.785535748 +0000
> +++ b/drivers/net/xen-netback/common.h 2016-12-23 13:08:18.123080064 +0000
> @@ -113,10 +113,10 @@ struct xenvif_stats {
> * A subset of struct net_device_stats that contains only the
> * fields that are updated in netback.c for each queue.
> */
> - unsigned int rx_bytes;
> - unsigned int rx_packets;
> - unsigned int tx_bytes;
> - unsigned int tx_packets;
> + unsigned long rx_bytes;
> + unsigned long rx_packets;
> + unsigned long tx_bytes;
> + unsigned long tx_packets;
>
> /* Additional stats used by xenvif */
> unsigned long rx_gso_checksum_fixup;
>
> --
> Mart van Santen
> Greenhost
> E: mart@greenhost.nl
> T: +31 20 4890444
> W: https://greenhost.nl
>
> A PGP signature can be attached to this e-mail,
> you need PGP software to verify it.
> My public key is available in keyserver(s)
> see: http://tinyurl.com/openpgp-manual
>
> PGP Fingerprint: CA85 EB11 2B70 042D AF66 B29A 6437 01A1 10A3 D3A5
>
>
prev parent reply other threads:[~2016-12-29 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 15:09 [PATCH] vif queue counters from int to long Mart van Santen
2016-12-26 16:35 ` [PATCH] vif queue counters from int to long,[PATCH] " David Miller
2016-12-29 10:47 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229104709.GY28690@citrix.com \
--to=wei.liu2@citrix.com \
--cc=mart@greenhost.nl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).