* [PATCH] vif queue counters from int to long
@ 2016-12-23 15:09 Mart van Santen
2016-12-26 16:35 ` [PATCH] vif queue counters from int to long,[PATCH] " David Miller
2016-12-29 10:47 ` [PATCH] " Wei Liu
0 siblings, 2 replies; 3+ messages in thread
From: Mart van Santen @ 2016-12-23 15:09 UTC (permalink / raw)
To: netdev; +Cc: ian.campbell, wei.liu2
[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]
Hello,
This patch fixes an issue where counters in the queue have type int,
while the counters of the vif itself are specified as long. This can
cause incorrect reporting of tx/rx values of the vif interface.
More extensively reported on xen-devel mailinglist.
Signed-off-by: Mart van Santen <mart@greenhost.nl>
--- a/drivers/net/xen-netback/common.h 2016-12-22 15:41:07.785535748 +0000
+++ b/drivers/net/xen-netback/common.h 2016-12-23 13:08:18.123080064 +0000
@@ -113,10 +113,10 @@ struct xenvif_stats {
* A subset of struct net_device_stats that contains only the
* fields that are updated in netback.c for each queue.
*/
- unsigned int rx_bytes;
- unsigned int rx_packets;
- unsigned int tx_bytes;
- unsigned int tx_packets;
+ unsigned long rx_bytes;
+ unsigned long rx_packets;
+ unsigned long tx_bytes;
+ unsigned long tx_packets;
/* Additional stats used by xenvif */
unsigned long rx_gso_checksum_fixup;
--
Mart van Santen
Greenhost
E: mart@greenhost.nl
T: +31 20 4890444
W: https://greenhost.nl
A PGP signature can be attached to this e-mail,
you need PGP software to verify it.
My public key is available in keyserver(s)
see: http://tinyurl.com/openpgp-manual
PGP Fingerprint: CA85 EB11 2B70 042D AF66 B29A 6437 01A1 10A3 D3A5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vif queue counters from int to long,[PATCH] vif queue counters from int to long
2016-12-23 15:09 [PATCH] vif queue counters from int to long Mart van Santen
@ 2016-12-26 16:35 ` David Miller
2016-12-29 10:47 ` [PATCH] " Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-12-26 16:35 UTC (permalink / raw)
To: mart; +Cc: netdev, ian.campbell, wei.liu2
From: Mart van Santen <mart@greenhost.nl>
Date: Fri, 23 Dec 2016 16:09:23 +0100
> This patch fixes an issue where counters in the queue have type int,
> while the counters of the vif itself are specified as long. This can
> cause incorrect reporting of tx/rx values of the vif interface.
> More extensively reported on xen-devel mailinglist.
>
> Signed-off-by: Mart van Santen <mart@greenhost.nl>
Your subject line lacks a proper subsystem prefix, in this case
an appropriate one might be "xen-netback: "
Also, your patch was corrupted by your email client, transforming
TAB characters into spaces. This makes the patch unusable.
Please read Documentation/email-clients.txt on how to fix this
and how to submit uncorrupted patches properly.
Email a test patch to yourself, and do not attempt to resend this
patch to the mailing list until you can successfully apply the test
patch you send to yourself.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vif queue counters from int to long
2016-12-23 15:09 [PATCH] vif queue counters from int to long Mart van Santen
2016-12-26 16:35 ` [PATCH] vif queue counters from int to long,[PATCH] " David Miller
@ 2016-12-29 10:47 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-12-29 10:47 UTC (permalink / raw)
To: Mart van Santen; +Cc: netdev, wei.liu2
On Fri, Dec 23, 2016 at 04:09:23PM +0100, Mart van Santen wrote:
>
> Hello,
>
> This patch fixes an issue where counters in the queue have type int,
> while the counters of the vif itself are specified as long. This can
> cause incorrect reporting of tx/rx values of the vif interface.
> More extensively reported on xen-devel mailinglist.
>
Hello,
Please also CC xen-devel@lists.xenproject.org for your future patch(es).
And please note that the most up to date maintainer information should
be used.
Wei.
>
>
> Signed-off-by: Mart van Santen <mart@greenhost.nl>
> --- a/drivers/net/xen-netback/common.h 2016-12-22 15:41:07.785535748 +0000
> +++ b/drivers/net/xen-netback/common.h 2016-12-23 13:08:18.123080064 +0000
> @@ -113,10 +113,10 @@ struct xenvif_stats {
> * A subset of struct net_device_stats that contains only the
> * fields that are updated in netback.c for each queue.
> */
> - unsigned int rx_bytes;
> - unsigned int rx_packets;
> - unsigned int tx_bytes;
> - unsigned int tx_packets;
> + unsigned long rx_bytes;
> + unsigned long rx_packets;
> + unsigned long tx_bytes;
> + unsigned long tx_packets;
>
> /* Additional stats used by xenvif */
> unsigned long rx_gso_checksum_fixup;
>
> --
> Mart van Santen
> Greenhost
> E: mart@greenhost.nl
> T: +31 20 4890444
> W: https://greenhost.nl
>
> A PGP signature can be attached to this e-mail,
> you need PGP software to verify it.
> My public key is available in keyserver(s)
> see: http://tinyurl.com/openpgp-manual
>
> PGP Fingerprint: CA85 EB11 2B70 042D AF66 B29A 6437 01A1 10A3 D3A5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-29 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-23 15:09 [PATCH] vif queue counters from int to long Mart van Santen
2016-12-26 16:35 ` [PATCH] vif queue counters from int to long,[PATCH] " David Miller
2016-12-29 10:47 ` [PATCH] " Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).