From: David Miller <davem@davemloft.net>
To: ptikhomirov@virtuozzo.com
Cc: edumazet@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, khorenko@virtuozzo.com
Subject: Re: [PATCH] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int
Date: Fri, 30 Dec 2016 15:23:25 -0500 (EST) [thread overview]
Message-ID: <20161230.152325.1460360247883491150.davem@davemloft.net> (raw)
In-Reply-To: <20161229143507.4934-1-ptikhomirov@virtuozzo.com>
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Date: Thu, 29 Dec 2016 17:35:07 +0300
> @@ -958,7 +959,9 @@ static struct ctl_table ipv4_net_table[] = {
> .data = &init_net.ipv4.sysctl_tcp_notsent_lowat,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_doulongvec_minmax,
> + .extra1 = &zero,
> + .extra2 = &uint_max,
It seems much simpler to use "proc_douintvec()" to fix this bug.
Doesn't it?
next prev parent reply other threads:[~2016-12-30 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 14:35 [PATCH] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int Pavel Tikhomirov
2016-12-30 20:23 ` David Miller [this message]
2017-01-09 7:45 ` [PATCH v2] " Pavel Tikhomirov
2017-01-09 21:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161230.152325.1460360247883491150.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=khorenko@virtuozzo.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).