From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
ilyal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
binoy.jayan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH for-next 03/11] IB/mlx5: Add helper mlx5_ib_post_send_wait
Date: Sun, 01 Jan 2017 21:10:26 -0500 (EST) [thread overview]
Message-ID: <20170101.211026.2671529442746711.davem@davemloft.net> (raw)
In-Reply-To: <1483305027-2573-4-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
From: Saeed Mahameed <saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date: Sun, 1 Jan 2017 23:10:19 +0200
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8f608deb..afb6dc1 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -891,16 +891,40 @@ static inline void mlx5_ib_init_umr_context(struct mlx5_ib_umr_context *context)
> init_completion(&context->done);
> }
>
> +static inline int mlx5_ib_post_send_wait(struct mlx5_ib_dev *dev,
> + struct mlx5_umr_wr *umrwr)
Please do not use 'inline' in foo.c files, let the compiler decide.
I know this is already happening in this file, but that should be
continued rather than replicated further.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-02 2:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 21:10 [PATCH for-next 00/11] Mellanox mlx5 core and ODP updates 2017-01-01 Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 01/11] net/mlx5: Fix offset naming for reserved fields in hca_cap_bits Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 04/11] net/mlx5: Support new MR features Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 05/11] IB/mlx5: Refactor UMR post send format Saeed Mahameed
2017-01-02 2:11 ` David Miller
2017-01-01 21:10 ` [PATCH for-next 06/11] IB/mlx5: Add support for big MRs Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 08/11] net/mlx5: Update PAGE_FAULT_RESUME layout Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 09/11] {net,IB}/mlx5: Refactor page fault handling Saeed Mahameed
[not found] ` <1483305027-2573-1-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-01 21:10 ` [PATCH for-next 02/11] IB/mlx5: Reorder code in query device command Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 03/11] IB/mlx5: Add helper mlx5_ib_post_send_wait Saeed Mahameed
[not found] ` <1483305027-2573-4-git-send-email-saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-02 2:10 ` David Miller [this message]
2017-01-01 21:10 ` [PATCH for-next 07/11] IB/mlx5: Add MR cache for large UMR regions Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 10/11] IB/mlx5: Add ODP atomics support Saeed Mahameed
2017-01-01 21:10 ` [PATCH for-next 11/11] IB/mlx5: Improve MR check Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170101.211026.2671529442746711.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=binoy.jayan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ilyal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).