From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org, sathya.perla@broadcom.com,
ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com
Subject: Re: [PATCH net] benet: stricter vxlan offloading check in be_features_check
Date: Tue, 03 Jan 2017 10:59:08 -0500 (EST) [thread overview]
Message-ID: <20170103.105908.383460652152996780.davem@davemloft.net> (raw)
In-Reply-To: <59e720bde70fb5226313c62d89b62cbbef25b3e2.1483455910.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Tue, 3 Jan 2017 16:26:04 +0100
> When VXLAN offloading is enabled, be_features_check() tries to check if
> an encapsulated packet is indeed a VXLAN packet. The check is not strict
> enough, and considers any UDP-encapsulated ethernet frame with a 8-byte
> tunnel header as being VXLAN. Unfortunately, both GENEVE and VXLAN-GPE
> have a 8-byte header, so they get through this check.
>
> Force the UDP destination port to be the one that has been offloaded to
> hardware.
>
> Without this, GENEVE-encapsulated packets can end up having an incorrect
> checksum when both a GENEVE and a VXLAN (offloaded) tunnel are
> configured.
>
> This is similar to commit a547224dceed ("mlx4e: Do not attempt to
> offload VXLAN ports that are unrecognized").
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied, thanks.
prev parent reply other threads:[~2017-01-03 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 15:26 [PATCH net] benet: stricter vxlan offloading check in be_features_check Sabrina Dubroca
2017-01-03 15:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103.105908.383460652152996780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=sd@queasysnail.net \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox