From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: wr0112358@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end
Date: Tue, 3 Jan 2017 11:04:43 -0500 [thread overview]
Message-ID: <20170103160443.GC11735@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20170103.095419.261470619535526723.davem@davemloft.net>
On Tue, Jan 03, 2017 at 09:54:19AM -0500, David Miller wrote:
> From: Reiter Wolfgang <wr0112358@gmail.com>
> Date: Tue, 3 Jan 2017 01:39:10 +0100
>
> > Final nlmsg_len field update must reflect inserted net_dm_drop_point
> > data.
> >
> > This patch depends on previous patch:
> > "drop_monitor: add missing call to genlmsg_end"
> >
> > Signed-off-by: Reiter Wolfgang <wr0112358@gmail.com>
>
> I don't understand why the current code doesn't work properly.
>
> All over the tree, the pattern is:
>
> x = genlmsg_put(skb, ...);
> ...
> genlmsg_end(skb, x);
>
> And that is exactly what the code is doing right now.
>
Because reset_per_cpu_data should close the use of of the established skb
that was being written to. Without this patch we add the END tlv to the skb
that is just getting started for use in the drop monitor, rather than for the
skb that is getting returned for use in sending up to user space listeners.
Or am I missing something?
next prev parent reply other threads:[~2017-01-03 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 0:39 [PATCH] drop_monitor: consider inserted data in genlmsg_end Reiter Wolfgang
2017-01-03 13:09 ` Neil Horman
2017-01-03 14:54 ` David Miller
2017-01-03 16:04 ` Neil Horman [this message]
2017-01-03 16:10 ` David Miller
2017-01-03 23:09 ` Wolfgang Reiter
-- strict thread matches above, loose matches on Subject: below --
2017-01-02 23:34 Reiter Wolfgang
2017-01-03 0:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103160443.GC11735@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wr0112358@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox